public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Halaney <ahalaney@redhat.com>
To: andersson@kernel.org
Cc: agross@kernel.org, konrad.dybcio@linaro.org, jejb@linux.ibm.com,
	martin.petersen@oracle.com, p.zabel@pengutronix.de,
	linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, manivannan.sadhasivam@linaro.org,
	Andrew Halaney <ahalaney@redhat.com>
Subject: [PATCH 1/4] scsi: ufs: ufs-qcom: Drop unnecessary NULL checks
Date: Thu,  1 Dec 2022 17:08:07 -0600	[thread overview]
Message-ID: <20221201230810.1019834-2-ahalaney@redhat.com> (raw)
In-Reply-To: <20221201230810.1019834-1-ahalaney@redhat.com>

This code path is only called through one function, and the hba
struct is already accessed in ufshcd_vops_dbg_register_dump() prior to
calling so there is no way for it to be NULL.

Likewise, the print_fn callback is always supplied within this driver
and is always provided.

Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
---
 drivers/ufs/host/ufs-qcom.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 8ad1415e10b6..70e25f9f8ca8 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -1202,15 +1202,6 @@ static void ufs_qcom_print_hw_debug_reg_all(struct ufs_hba *hba,
 	u32 reg;
 	struct ufs_qcom_host *host;
 
-	if (unlikely(!hba)) {
-		pr_err("%s: hba is NULL\n", __func__);
-		return;
-	}
-	if (unlikely(!print_fn)) {
-		dev_err(hba->dev, "%s: print_fn is NULL\n", __func__);
-		return;
-	}
-
 	host = ufshcd_get_variant(hba);
 	if (!(host->dbg_print_en & UFS_QCOM_DBG_PRINT_REGS_EN))
 		return;
-- 
2.38.1


  reply	other threads:[~2022-12-01 23:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-01 23:08 [PATCH 0/4] scsi: ufs: ufs-qcom: Debug clean ups Andrew Halaney
2022-12-01 23:08 ` Andrew Halaney [this message]
2022-12-02  7:36   ` [PATCH 1/4] scsi: ufs: ufs-qcom: Drop unnecessary NULL checks Manivannan Sadhasivam
2022-12-01 23:08 ` [PATCH 2/4] scsi: ufs: ufs-qcom: Clean up dbg_register_dump Andrew Halaney
2022-12-02  7:38   ` Manivannan Sadhasivam
2022-12-01 23:08 ` [PATCH 3/4] scsi: ufs: ufs-qcom: Remove usage of dbg_print_en Andrew Halaney
2022-12-02  7:39   ` Manivannan Sadhasivam
2022-12-01 23:08 ` [PATCH 4/4] scsi: ufs: ufs-qcom: Use dev_err() where possible Andrew Halaney
2022-12-02  7:40   ` Manivannan Sadhasivam
2022-12-01 23:54 ` [PATCH 0/4] scsi: ufs: ufs-qcom: Debug clean ups Asutosh Das
2022-12-30 21:12 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221201230810.1019834-2-ahalaney@redhat.com \
    --to=ahalaney@redhat.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=jejb@linux.ibm.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=martin.petersen@oracle.com \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox