From: Andrew Halaney <ahalaney@redhat.com>
To: andersson@kernel.org
Cc: agross@kernel.org, konrad.dybcio@linaro.org, jejb@linux.ibm.com,
martin.petersen@oracle.com, p.zabel@pengutronix.de,
linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, manivannan.sadhasivam@linaro.org,
Andrew Halaney <ahalaney@redhat.com>
Subject: [PATCH 4/4] scsi: ufs: ufs-qcom: Use dev_err() where possible
Date: Thu, 1 Dec 2022 17:08:10 -0600 [thread overview]
Message-ID: <20221201230810.1019834-5-ahalaney@redhat.com> (raw)
In-Reply-To: <20221201230810.1019834-1-ahalaney@redhat.com>
dev_err() statements are better to use than pr_err(), so switch to
those.
In a similar vein, the check on the dev_req_params pointer here is
not needed, the two places this function is called never pass in a
NULL pointer, so instead of using dev_err() there just remove it.
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
---
drivers/ufs/host/ufs-qcom.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index b1fcff1fad0c..4350c44a6fc7 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -680,12 +680,6 @@ static int ufs_qcom_pwr_change_notify(struct ufs_hba *hba,
struct ufs_dev_params ufs_qcom_cap;
int ret = 0;
- if (!dev_req_params) {
- pr_err("%s: incoming dev_req_params is NULL\n", __func__);
- ret = -EINVAL;
- goto out;
- }
-
switch (status) {
case PRE_CHANGE:
ufshcd_init_pwr_dev_param(&ufs_qcom_cap);
@@ -709,7 +703,7 @@ static int ufs_qcom_pwr_change_notify(struct ufs_hba *hba,
dev_max_params,
dev_req_params);
if (ret) {
- pr_err("%s: failed to determine capabilities\n",
+ dev_err(hba->dev, "%s: failed to determine capabilities\n",
__func__);
goto out;
}
--
2.38.1
next prev parent reply other threads:[~2022-12-01 23:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 23:08 [PATCH 0/4] scsi: ufs: ufs-qcom: Debug clean ups Andrew Halaney
2022-12-01 23:08 ` [PATCH 1/4] scsi: ufs: ufs-qcom: Drop unnecessary NULL checks Andrew Halaney
2022-12-02 7:36 ` Manivannan Sadhasivam
2022-12-01 23:08 ` [PATCH 2/4] scsi: ufs: ufs-qcom: Clean up dbg_register_dump Andrew Halaney
2022-12-02 7:38 ` Manivannan Sadhasivam
2022-12-01 23:08 ` [PATCH 3/4] scsi: ufs: ufs-qcom: Remove usage of dbg_print_en Andrew Halaney
2022-12-02 7:39 ` Manivannan Sadhasivam
2022-12-01 23:08 ` Andrew Halaney [this message]
2022-12-02 7:40 ` [PATCH 4/4] scsi: ufs: ufs-qcom: Use dev_err() where possible Manivannan Sadhasivam
2022-12-01 23:54 ` [PATCH 0/4] scsi: ufs: ufs-qcom: Debug clean ups Asutosh Das
2022-12-30 21:12 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221201230810.1019834-5-ahalaney@redhat.com \
--to=ahalaney@redhat.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox