From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
Avri Altman <avri.altman@wdc.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Asutosh Das <asutoshd@codeaurora.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Bean Huo <beanhuo@micron.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Jinyoung Choi <j-young.choi@samsung.com>
Subject: [PATCH 2/2] scsi: ufs: Use SYNCHRONIZE CACHE instead of FUA
Date: Wed, 1 Feb 2023 10:06:37 -0800 [thread overview]
Message-ID: <20230201180637.2102556-3-bvanassche@acm.org> (raw)
In-Reply-To: <20230201180637.2102556-1-bvanassche@acm.org>
From: Asutosh Das <asutoshd@codeaurora.org>
UFS devices perform better when using SYNCHRONIZE CACHE command
instead of the FUA flag. Hence this patch.
Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
[ bvanassche: modified a source code comment ]
---
drivers/ufs/core/ufshcd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index bf3cb12ef02f..461aa51cfccc 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -5056,6 +5056,9 @@ static int ufshcd_slave_alloc(struct scsi_device *sdev)
/* WRITE_SAME command is not supported */
sdev->no_write_same = 1;
+ /* Use SYNCHRONIZE CACHE instead of FUA to improve performance */
+ sdev->sdev_bflags = BLIST_BROKEN_FUA;
+
ufshcd_lu_init(hba, sdev);
ufshcd_setup_links(hba, sdev);
next prev parent reply other threads:[~2023-02-01 18:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 18:06 [PATCH 0/2] Use SYNCHRONIZE CACHE instead of FUA for UFS devices Bart Van Assche
2023-02-01 18:06 ` [PATCH 1/2] scsi: core: Introduce the BLIST_BROKEN_FUA flag Bart Van Assche
2023-02-01 18:06 ` Bart Van Assche [this message]
2023-02-02 1:54 ` [PATCH 2/2] scsi: ufs: Use SYNCHRONIZE CACHE instead of FUA Daejun Park
2023-02-02 4:32 ` kernel test robot
2023-02-02 7:52 ` Adrian Hunter
2023-02-02 18:09 ` Bart Van Assche
2023-02-02 18:46 ` James Bottomley
2023-02-02 19:00 ` Bart Van Assche
2023-02-02 22:13 ` James Bottomley
2023-02-02 9:01 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230201180637.2102556-3-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=j-young.choi@samsung.com \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox