[PATCH] scsi: mpi3mr: fix an issue found by KASAN

[PATCH] scsi: mpi3mr: fix an issue found by KASAN

[Tomas Henzl]

Write only correct size (32 instead of 64 bytes).

Fixes: 42fc9fee116fc ("scsi: mpi3mr: Add helper functions to manage device's port")
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
---
 drivers/scsi/mpi3mr/mpi3mr_transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/mpi3mr/mpi3mr_transport.c b/drivers/scsi/mpi3mr/mpi3mr_transport.c
index 3fc897336b5e..3b61815979da 100644
--- a/drivers/scsi/mpi3mr/mpi3mr_transport.c
+++ b/drivers/scsi/mpi3mr/mpi3mr_transport.c
@@ -1280,7 +1280,7 @@ void mpi3mr_sas_host_add(struct mpi3mr_ioc *mrioc)
 
 	if (mrioc->sas_hba.enclosure_handle) {
 		if (!(mpi3mr_cfg_get_enclosure_pg0(mrioc, &ioc_status,
-		    &encl_pg0, sizeof(dev_pg0),
+		    &encl_pg0, sizeof(encl_pg0),
 		    MPI3_ENCLOS_PGAD_FORM_HANDLE,
 		    mrioc->sas_hba.enclosure_handle)) &&
 		    (ioc_status == MPI3_IOCSTATUS_SUCCESS))
-- 
2.39.1

Re: [PATCH] scsi: mpi3mr: fix an issue found by KASAN

[Sathya Prakash Veerichetty]

[-- Attachment #1: Type: text/plain, Size: 1942 bytes --]

On Mon, Feb 13, 2023 at 12:37 PM Tomas Henzl <thenzl@redhat.com> wrote:
>
> Write only correct size (32 instead of 64 bytes).
>
> Fixes: 42fc9fee116fc ("scsi: mpi3mr: Add helper functions to manage device's port")
> Signed-off-by: Tomas Henzl <thenzl@redhat.com>
> ---
Acked-by: Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>
>  drivers/scsi/mpi3mr/mpi3mr_transport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/mpi3mr/mpi3mr_transport.c b/drivers/scsi/mpi3mr/mpi3mr_transport.c
> index 3fc897336b5e..3b61815979da 100644
> --- a/drivers/scsi/mpi3mr/mpi3mr_transport.c
> +++ b/drivers/scsi/mpi3mr/mpi3mr_transport.c
> @@ -1280,7 +1280,7 @@ void mpi3mr_sas_host_add(struct mpi3mr_ioc *mrioc)
>
>         if (mrioc->sas_hba.enclosure_handle) {
>                 if (!(mpi3mr_cfg_get_enclosure_pg0(mrioc, &ioc_status,
> -                   &encl_pg0, sizeof(dev_pg0),
> +                   &encl_pg0, sizeof(encl_pg0),
>                     MPI3_ENCLOS_PGAD_FORM_HANDLE,
>                     mrioc->sas_hba.enclosure_handle)) &&
>                     (ioc_status == MPI3_IOCSTATUS_SUCCESS))
> --
> 2.39.1
>

-- 
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4227 bytes --]

Re: [PATCH] scsi: mpi3mr: fix an issue found by KASAN

[Martin K. Petersen]

Tomas,

> Write only correct size (32 instead of 64 bytes).

Applied to 6.3/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering