* [PATCH 1/3] megaraid_sas: Update max supported LD IDs to 240
2023-03-02 10:53 [PATCH 0/3] Driver version update to 07.725.01.00-rc1 Chandrakanth Patil
@ 2023-03-02 10:53 ` Chandrakanth Patil
2023-03-02 10:53 ` [PATCH 2/3] megaraid_sas: Add crash dump mode capability bit in MFI capabilities Chandrakanth Patil
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Chandrakanth Patil @ 2023-03-02 10:53 UTC (permalink / raw)
To: linux-scsi; +Cc: sumit.saxena, Chandrakanth Patil
[-- Attachment #1: Type: text/plain, Size: 1806 bytes --]
As of now, The firmware only supports LD IDs up to 240, and LD ID 255
(0xFF) being reserved for deleted LDs. However, in some cases, firmware
was assigning LD ID 254 (0xFE) to deleted LDs which was causing the
driver to delete the wrong LD.
To address this issue, the driver updated the LD ID check from 255 to
240, This ensures the deleted LD ID properly identifies and removed by
the driver without accidently deleting the valid LDs.
Signed-off-by: Chandrakanth Patil <chandrakanth.patil@broadcom.com>
Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com>
---
drivers/scsi/megaraid/megaraid_sas.h | 2 ++
drivers/scsi/megaraid/megaraid_sas_fp.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h
index 4919ea54b827..2ef9d41fc6f4 100644
--- a/drivers/scsi/megaraid/megaraid_sas.h
+++ b/drivers/scsi/megaraid/megaraid_sas.h
@@ -1519,6 +1519,8 @@ struct megasas_ctrl_info {
#define MEGASAS_MAX_LD_IDS (MEGASAS_MAX_LD_CHANNELS * \
MEGASAS_MAX_DEV_PER_CHANNEL)
+#define MEGASAS_MAX_SUPPORTED_LD_IDS 240
+
#define MEGASAS_MAX_SECTORS (2*1024)
#define MEGASAS_MAX_SECTORS_IEEE (2*128)
#define MEGASAS_DBG_LVL 1
diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c b/drivers/scsi/megaraid/megaraid_sas_fp.c
index da1cad1ee123..4463a538102a 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fp.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
@@ -358,7 +358,7 @@ u8 MR_ValidateMapInfo(struct megasas_instance *instance, u64 map_id)
ld = MR_TargetIdToLdGet(i, drv_map);
/* For non existing VDs, iterate to next VD*/
- if (ld >= (MAX_LOGICAL_DRIVES_EXT - 1))
+ if (ld >= MEGASAS_MAX_SUPPORTED_LD_IDS)
continue;
raid = MR_LdRaidGet(ld, drv_map);
--
2.31.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4227 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/3] megaraid_sas: Add crash dump mode capability bit in MFI capabilities
2023-03-02 10:53 [PATCH 0/3] Driver version update to 07.725.01.00-rc1 Chandrakanth Patil
2023-03-02 10:53 ` [PATCH 1/3] megaraid_sas: Update max supported LD IDs to 240 Chandrakanth Patil
@ 2023-03-02 10:53 ` Chandrakanth Patil
2023-03-02 10:53 ` [PATCH 3/3] Driver version update to 07.725.01.00-rc1 Chandrakanth Patil
2023-03-07 2:57 ` [PATCH 0/3] " Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Chandrakanth Patil @ 2023-03-02 10:53 UTC (permalink / raw)
To: linux-scsi; +Cc: sumit.saxena, Chandrakanth Patil
[-- Attachment #1: Type: text/plain, Size: 2134 bytes --]
In kdump kernel mode, the driver works in reduced functionality mode with
some features disabled such as reduced MSIX count and RDPQ disabled etc.
However, the firmware is not aware of this mode, in some cases, which
results in undefined behavior.
To address this, the driver informs the firmware about the kdump mode
driver through MPI capabilities bit during driver initialization.
So firmware can adjust its behavior accordingly.
Signed-off-by: Chandrakanth Patil <chandrakanth.patil@broadcom.com>
Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com>
---
drivers/scsi/megaraid/megaraid_sas.h | 6 ++++--
drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 +++
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h
index 2ef9d41fc6f4..c2bace65105b 100644
--- a/drivers/scsi/megaraid/megaraid_sas.h
+++ b/drivers/scsi/megaraid/megaraid_sas.h
@@ -1760,7 +1760,8 @@ union megasas_sgl_frame {
typedef union _MFI_CAPABILITIES {
struct {
#if defined(__BIG_ENDIAN_BITFIELD)
- u32 reserved:16;
+ u32 reserved:15;
+ u32 support_memdump:1;
u32 support_fw_exposed_dev_list:1;
u32 support_nvme_passthru:1;
u32 support_64bit_mode:1;
@@ -1794,7 +1795,8 @@ typedef union _MFI_CAPABILITIES {
u32 support_64bit_mode:1;
u32 support_nvme_passthru:1;
u32 support_fw_exposed_dev_list:1;
- u32 reserved:16;
+ u32 support_memdump:1;
+ u32 reserved:15;
#endif
} mfi_capabilities;
__le32 reg;
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index fe70f8f11435..7ebfbe0c2ba7 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -1201,6 +1201,9 @@ megasas_ioc_init_fusion(struct megasas_instance *instance)
drv_ops->mfi_capabilities.support_nvme_passthru = 1;
drv_ops->mfi_capabilities.support_fw_exposed_dev_list = 1;
+ if (reset_devices)
+ drv_ops->mfi_capabilities.support_memdump = 1;
+
if (instance->consistent_mask_64bit)
drv_ops->mfi_capabilities.support_64bit_mode = 1;
--
2.31.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4227 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 3/3] Driver version update to 07.725.01.00-rc1
2023-03-02 10:53 [PATCH 0/3] Driver version update to 07.725.01.00-rc1 Chandrakanth Patil
2023-03-02 10:53 ` [PATCH 1/3] megaraid_sas: Update max supported LD IDs to 240 Chandrakanth Patil
2023-03-02 10:53 ` [PATCH 2/3] megaraid_sas: Add crash dump mode capability bit in MFI capabilities Chandrakanth Patil
@ 2023-03-02 10:53 ` Chandrakanth Patil
2023-03-07 2:57 ` [PATCH 0/3] " Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Chandrakanth Patil @ 2023-03-02 10:53 UTC (permalink / raw)
To: linux-scsi; +Cc: sumit.saxena, Chandrakanth Patil
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
Signed-off-by: Chandrakanth Patil <chandrakanth.patil@broadcom.com>
---
drivers/scsi/megaraid/megaraid_sas.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h
index c2bace65105b..63bac3684c19 100644
--- a/drivers/scsi/megaraid/megaraid_sas.h
+++ b/drivers/scsi/megaraid/megaraid_sas.h
@@ -23,8 +23,8 @@
/*
* MegaRAID SAS Driver meta data
*/
-#define MEGASAS_VERSION "07.719.03.00-rc1"
-#define MEGASAS_RELDATE "Sep 29, 2021"
+#define MEGASAS_VERSION "07.725.01.00-rc1"
+#define MEGASAS_RELDATE "Mar 2, 2023"
#define MEGASAS_MSIX_NAME_LEN 32
--
2.31.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4227 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 0/3] Driver version update to 07.725.01.00-rc1
2023-03-02 10:53 [PATCH 0/3] Driver version update to 07.725.01.00-rc1 Chandrakanth Patil
` (2 preceding siblings ...)
2023-03-02 10:53 ` [PATCH 3/3] Driver version update to 07.725.01.00-rc1 Chandrakanth Patil
@ 2023-03-07 2:57 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2023-03-07 2:57 UTC (permalink / raw)
To: linux-scsi, Chandrakanth Patil; +Cc: Martin K . Petersen, sumit.saxena
On Thu, 02 Mar 2023 16:23:39 +0530, Chandrakanth Patil wrote:
> This patchset contains two critical fixes.
>
> Chandrakanth Patil (3):
> megaraid_sas: Update max supported LD IDs to 240
> megaraid_sas: Add crash dump mode capability bit in MFI capabilities
> Driver version update to 07.725.01.00-rc1
>
> [...]
Applied to 6.3/scsi-fixes, thanks!
[1/3] megaraid_sas: Update max supported LD IDs to 240
https://git.kernel.org/mkp/scsi/c/bfa659177dcb
[2/3] megaraid_sas: Add crash dump mode capability bit in MFI capabilities
https://git.kernel.org/mkp/scsi/c/9bcb1d5a3d10
[3/3] Driver version update to 07.725.01.00-rc1
https://git.kernel.org/mkp/scsi/c/a2033f9f9d78
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread