From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Benjamin Block <bblock@linux.ibm.com>,
John Garry <john.g.garry@oracle.com>,
Ming Lei <ming.lei@redhat.com>, Christoph Hellwig <hch@lst.de>,
Hannes Reinecke <hare@suse.de>,
Mike Christie <michael.christie@oracle.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: [PATCH v2 02/82] scsi: core: Declare most SCSI host template pointers const
Date: Thu, 9 Mar 2023 11:24:54 -0800 [thread overview]
Message-ID: <20230309192614.2240602-3-bvanassche@acm.org> (raw)
In-Reply-To: <20230309192614.2240602-1-bvanassche@acm.org>
Prepare for constifying most SCSI host template pointers by constifying
the SCSI host template pointer arguments and variables in the SCSI core.
Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
Reviewed-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/scsi/scsi_error.c | 16 ++++++++--------
drivers/scsi/scsi_sysfs.c | 6 +++---
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index 2aa2c2aee6e7..3ec8bfd4090f 100644
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -58,7 +58,7 @@
#define HOST_RESET_SETTLE_TIME (10)
static int scsi_eh_try_stu(struct scsi_cmnd *scmd);
-static enum scsi_disposition scsi_try_to_abort_cmd(struct scsi_host_template *,
+static enum scsi_disposition scsi_try_to_abort_cmd(const struct scsi_host_template *,
struct scsi_cmnd *);
void scsi_eh_wakeup(struct Scsi_Host *shost)
@@ -699,7 +699,7 @@ EXPORT_SYMBOL_GPL(scsi_check_sense);
static void scsi_handle_queue_ramp_up(struct scsi_device *sdev)
{
- struct scsi_host_template *sht = sdev->host->hostt;
+ const struct scsi_host_template *sht = sdev->host->hostt;
struct scsi_device *tmp_sdev;
if (!sht->track_queue_depth ||
@@ -731,7 +731,7 @@ static void scsi_handle_queue_ramp_up(struct scsi_device *sdev)
static void scsi_handle_queue_full(struct scsi_device *sdev)
{
- struct scsi_host_template *sht = sdev->host->hostt;
+ const struct scsi_host_template *sht = sdev->host->hostt;
struct scsi_device *tmp_sdev;
if (!sht->track_queue_depth)
@@ -840,7 +840,7 @@ static enum scsi_disposition scsi_try_host_reset(struct scsi_cmnd *scmd)
unsigned long flags;
enum scsi_disposition rtn;
struct Scsi_Host *host = scmd->device->host;
- struct scsi_host_template *hostt = host->hostt;
+ const struct scsi_host_template *hostt = host->hostt;
SCSI_LOG_ERROR_RECOVERY(3,
shost_printk(KERN_INFO, host, "Snd Host RST\n"));
@@ -870,7 +870,7 @@ static enum scsi_disposition scsi_try_bus_reset(struct scsi_cmnd *scmd)
unsigned long flags;
enum scsi_disposition rtn;
struct Scsi_Host *host = scmd->device->host;
- struct scsi_host_template *hostt = host->hostt;
+ const struct scsi_host_template *hostt = host->hostt;
SCSI_LOG_ERROR_RECOVERY(3, scmd_printk(KERN_INFO, scmd,
"%s: Snd Bus RST\n", __func__));
@@ -912,7 +912,7 @@ static enum scsi_disposition scsi_try_target_reset(struct scsi_cmnd *scmd)
unsigned long flags;
enum scsi_disposition rtn;
struct Scsi_Host *host = scmd->device->host;
- struct scsi_host_template *hostt = host->hostt;
+ const struct scsi_host_template *hostt = host->hostt;
if (!hostt->eh_target_reset_handler)
return FAILED;
@@ -941,7 +941,7 @@ static enum scsi_disposition scsi_try_target_reset(struct scsi_cmnd *scmd)
static enum scsi_disposition scsi_try_bus_device_reset(struct scsi_cmnd *scmd)
{
enum scsi_disposition rtn;
- struct scsi_host_template *hostt = scmd->device->host->hostt;
+ const struct scsi_host_template *hostt = scmd->device->host->hostt;
if (!hostt->eh_device_reset_handler)
return FAILED;
@@ -970,7 +970,7 @@ static enum scsi_disposition scsi_try_bus_device_reset(struct scsi_cmnd *scmd)
* link down on FibreChannel)
*/
static enum scsi_disposition
-scsi_try_to_abort_cmd(struct scsi_host_template *hostt, struct scsi_cmnd *scmd)
+scsi_try_to_abort_cmd(const struct scsi_host_template *hostt, struct scsi_cmnd *scmd)
{
if (!hostt->eh_abort_handler)
return FAILED;
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index ee28f73af4d4..603e8fcfcb8a 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/drivers/scsi/scsi_sysfs.c
@@ -296,7 +296,7 @@ store_host_reset(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count)
{
struct Scsi_Host *shost = class_to_shost(dev);
- struct scsi_host_template *sht = shost->hostt;
+ const struct scsi_host_template *sht = shost->hostt;
int ret = -EINVAL;
int type;
@@ -1025,7 +1025,7 @@ sdev_store_queue_depth(struct device *dev, struct device_attribute *attr,
{
int depth, retval;
struct scsi_device *sdev = to_scsi_device(dev);
- struct scsi_host_template *sht = sdev->host->hostt;
+ const struct scsi_host_template *sht = sdev->host->hostt;
if (!sht->change_queue_depth)
return -EINVAL;
@@ -1606,7 +1606,7 @@ void scsi_sysfs_device_initialize(struct scsi_device *sdev)
{
unsigned long flags;
struct Scsi_Host *shost = sdev->host;
- struct scsi_host_template *hostt = shost->hostt;
+ const struct scsi_host_template *hostt = shost->hostt;
struct scsi_target *starget = sdev->sdev_target;
device_initialize(&sdev->sdev_gendev);
next prev parent reply other threads:[~2023-03-09 19:26 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 19:24 [PATCH v2 00/82] Constify most SCSI host templates Bart Van Assche
2023-03-09 19:24 ` [PATCH v2 01/82] scsi: qla2xxx: Refer directly to the qla2xxx_driver_template Bart Van Assche
2023-03-09 19:24 ` Bart Van Assche [this message]
2023-03-09 19:24 ` [PATCH v2 03/82] scsi: core: Declare SCSI host template pointer members const Bart Van Assche
2023-03-10 9:24 ` John Garry
2023-03-09 19:24 ` [PATCH v2 04/82] ata: Declare SCSI host templates const Bart Van Assche
2023-03-09 23:36 ` Serge Semin
2023-03-10 9:17 ` John Garry
2023-03-10 14:54 ` Jon Hunter
2023-03-09 19:24 ` [PATCH v2 05/82] firewire: sbp2: Declare the SCSI host template const Bart Van Assche
2023-03-09 19:24 ` [PATCH v2 06/82] RDMA/srp: " Bart Van Assche
2023-03-13 13:03 ` Leon Romanovsky
2023-03-09 19:24 ` [PATCH v2 07/82] scsi: message: fusion: Declare SCSI host template members const Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 08/82] scsi: zfcp: Declare SCSI host template const Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 09/82] scsi: 3w-9xxx: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 10/82] scsi: 3w-sas: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 11/82] scsi: 3w-xxxx: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 12/82] scsi: BusLogic: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 13/82] scsi: a100u2w: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 14/82] scsi: a2091: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 15/82] scsi: a3000: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 16/82] scsi: aacraid: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 17/82] scsi: advansys: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 18/82] scsi: aha152x: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 19/82] scsi: aha1542: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 20/82] scsi: aic94xx: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 21/82] scsi: arcmsr: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 22/82] scsi: acornscsi: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 23/82] scsi: arxescsi: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 24/82] scsi: aha1740: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 25/82] scsi: cumana: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 26/82] scsi: eesox: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 27/82] scsi: oak: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 28/82] scsi: powertec: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 29/82] scsi: atp870u: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 30/82] scsi: dc395x: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 31/82] scsi: dmx3191d: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 32/82] scsi: elx: efct: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 33/82] scsi: esas2r: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 34/82] scsi: esp_scsi: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 35/82] scsi: fcoe: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 36/82] scsi: fnic: Declare " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 37/82] scsi: qedf: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 38/82] scsi: fdomain: Declare SCSI " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 39/82] scsi: NCR5380: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 40/82] scsi: gvp11: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 41/82] scsi: hisi_sas: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 42/82] scsi: hpsa: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 43/82] scsi: hptiop: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 44/82] scsi: ibmvfc: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 45/82] scsi: imm: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 46/82] scsi: initio: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 47/82] scsi: ipr: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 48/82] scsi: isci: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 49/82] scsi: iscsi: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 50/82] scsi: mac53c94: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 51/82] scsi: mac_scsi: " Bart Van Assche
2023-03-10 4:46 ` Finn Thain
2023-03-10 6:09 ` Michael Schmitz
2023-03-10 18:28 ` Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 52/82] scsi: megaraid: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 53/82] scsi: mesh: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 54/82] scsi: mpi3mr: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 55/82] scsi: mpt3sas: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 56/82] scsi: mvme147: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 57/82] scsi: mvsas: " Bart Van Assche
2023-03-10 9:17 ` John Garry
2023-03-09 19:25 ` [PATCH v2 58/82] scsi: mvumi: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 59/82] scsi: myrb: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 60/82] scsi: myrs: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 61/82] scsi: nsp32: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 62/82] scsi: pcmcia-sym53c500: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 63/82] scsi: pcmcia-pm8001: " Bart Van Assche
2023-03-10 6:31 ` Jinpu Wang
2023-03-09 19:25 ` [PATCH v2 64/82] scsi: pmcraid: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 65/82] scsi: ppa: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 66/82] scsi: ps3rom: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 67/82] scsi: qla1280: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 68/82] scsi: qla2xxx: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 69/82] scsi: qlogicpti: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 70/82] scsi: sgiwd93: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 71/82] scsi: smartpqi: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 72/82] scsi: snic: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 73/82] scsi: stex: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 74/82] scsi: sym53c8xx: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 75/82] scsi: virtio-scsi: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 76/82] scsi: wd719x: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 77/82] scsi: xen-scsifront: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 78/82] scsi: rts5208: " Bart Van Assche
2023-03-10 7:32 ` Greg Kroah-Hartman
2023-03-09 19:26 ` [PATCH v2 79/82] scsi: target: tcm-loop: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 80/82] scsi: ufs: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 81/82] usb: uas: Declare two host templates and host template pointers const Bart Van Assche
2023-03-10 7:13 ` Greg Kroah-Hartman
2023-03-09 19:26 ` [PATCH v2 82/82] scsi: core: Update a source code comment Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230309192614.2240602-3-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=bblock@linux.ibm.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=john.g.garry@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox