public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: Bart Van Assche <bvanassche@acm.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>,
	Christoph Hellwig <hch@lst.de>, Ming Lei <ming.lei@redhat.com>,
	Hannes Reinecke <hare@suse.de>,
	John Garry <john.g.garry@oracle.com>,
	Mike Christie <michael.christie@oracle.com>,
	Serge Semin <fancer.lancer@gmail.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Hans de Goede <hdegoede@redhat.com>, Jens Axboe <axboe@kernel.dk>,
	Patrice Chotard <patrice.chotard@foss.st.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Viresh Kumar <vireshk@kernel.org>,
	Mikael Pettersson <mikpelinux@gmail.com>,
	Ondrej Zary <linux@zary.sk>, Sergey Shtylyov <s.shtylyov@omp.ru>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v2 04/82] ata: Declare SCSI host templates const
Date: Fri, 10 Mar 2023 14:54:47 +0000	[thread overview]
Message-ID: <709a7ebf-22d8-7349-d852-9324eb61e3cb@nvidia.com> (raw)
In-Reply-To: <20230309192614.2240602-5-bvanassche@acm.org>



On 09/03/2023 19:24, Bart Van Assche wrote:
> Make it explicit that ATA host templates are not modified.
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Ming Lei <ming.lei@redhat.com>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: John Garry <john.g.garry@oracle.com>
> Cc: Mike Christie <michael.christie@oracle.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
>   drivers/ata/acard-ahci.c                |  2 +-
>   drivers/ata/ahci.c                      |  2 +-
>   drivers/ata/ahci.h                      |  2 +-
>   drivers/ata/ahci_brcm.c                 |  2 +-
>   drivers/ata/ahci_ceva.c                 |  2 +-
>   drivers/ata/ahci_da850.c                |  2 +-
>   drivers/ata/ahci_dm816.c                |  2 +-
>   drivers/ata/ahci_dwc.c                  |  2 +-
>   drivers/ata/ahci_imx.c                  |  2 +-
>   drivers/ata/ahci_mtk.c                  |  2 +-
>   drivers/ata/ahci_mvebu.c                |  2 +-
>   drivers/ata/ahci_platform.c             |  2 +-
>   drivers/ata/ahci_qoriq.c                |  2 +-
>   drivers/ata/ahci_seattle.c              |  2 +-
>   drivers/ata/ahci_st.c                   |  2 +-
>   drivers/ata/ahci_sunxi.c                |  2 +-
>   drivers/ata/ahci_tegra.c                |  2 +-
>   drivers/ata/ahci_xgene.c                |  2 +-
>   drivers/ata/ata_generic.c               |  2 +-
>   drivers/ata/ata_piix.c                  |  6 +++---
>   drivers/ata/libahci.c                   |  4 ++--
>   drivers/ata/libahci_platform.c          |  2 +-
>   drivers/ata/libata-core.c               |  4 ++--
>   drivers/ata/libata-scsi.c               |  2 +-
>   drivers/ata/libata-sff.c                |  8 ++++----
>   drivers/ata/libata.h                    |  2 +-
>   drivers/ata/pata_acpi.c                 |  2 +-
>   drivers/ata/pata_ali.c                  |  2 +-
>   drivers/ata/pata_amd.c                  |  2 +-
>   drivers/ata/pata_arasan_cf.c            |  2 +-
>   drivers/ata/pata_artop.c                |  2 +-
>   drivers/ata/pata_atiixp.c               |  2 +-
>   drivers/ata/pata_atp867x.c              |  2 +-
>   drivers/ata/pata_buddha.c               |  2 +-
>   drivers/ata/pata_cmd640.c               |  2 +-
>   drivers/ata/pata_cmd64x.c               |  2 +-
>   drivers/ata/pata_cs5520.c               |  2 +-
>   drivers/ata/pata_cs5530.c               |  2 +-
>   drivers/ata/pata_cs5535.c               |  2 +-
>   drivers/ata/pata_cs5536.c               |  2 +-
>   drivers/ata/pata_cypress.c              |  2 +-
>   drivers/ata/pata_efar.c                 |  2 +-
>   drivers/ata/pata_ep93xx.c               |  2 +-
>   drivers/ata/pata_falcon.c               |  2 +-
>   drivers/ata/pata_ftide010.c             |  2 +-
>   drivers/ata/pata_gayle.c                |  2 +-
>   drivers/ata/pata_hpt366.c               |  2 +-
>   drivers/ata/pata_hpt37x.c               |  2 +-
>   drivers/ata/pata_hpt3x2n.c              |  2 +-
>   drivers/ata/pata_hpt3x3.c               |  2 +-
>   drivers/ata/pata_icside.c               |  2 +-
>   drivers/ata/pata_imx.c                  |  2 +-
>   drivers/ata/pata_isapnp.c               |  2 +-
>   drivers/ata/pata_it8213.c               |  2 +-
>   drivers/ata/pata_it821x.c               |  2 +-
>   drivers/ata/pata_ixp4xx_cf.c            |  2 +-
>   drivers/ata/pata_jmicron.c              |  2 +-
>   drivers/ata/pata_legacy.c               |  2 +-
>   drivers/ata/pata_macio.c                |  2 +-
>   drivers/ata/pata_marvell.c              |  2 +-
>   drivers/ata/pata_mpc52xx.c              |  2 +-
>   drivers/ata/pata_mpiix.c                |  2 +-
>   drivers/ata/pata_netcell.c              |  2 +-
>   drivers/ata/pata_ninja32.c              |  2 +-
>   drivers/ata/pata_ns87410.c              |  2 +-
>   drivers/ata/pata_ns87415.c              |  2 +-
>   drivers/ata/pata_octeon_cf.c            |  2 +-
>   drivers/ata/pata_of_platform.c          |  2 +-
>   drivers/ata/pata_oldpiix.c              |  2 +-
>   drivers/ata/pata_opti.c                 |  2 +-
>   drivers/ata/pata_optidma.c              |  2 +-
>   drivers/ata/pata_parport/pata_parport.c |  2 +-
>   drivers/ata/pata_pcmcia.c               |  2 +-
>   drivers/ata/pata_pdc2027x.c             |  2 +-
>   drivers/ata/pata_pdc202xx_old.c         |  2 +-
>   drivers/ata/pata_piccolo.c              |  2 +-
>   drivers/ata/pata_platform.c             |  4 ++--
>   drivers/ata/pata_pxa.c                  |  2 +-
>   drivers/ata/pata_radisys.c              |  2 +-
>   drivers/ata/pata_rb532_cf.c             |  2 +-
>   drivers/ata/pata_rdc.c                  |  2 +-
>   drivers/ata/pata_rz1000.c               |  2 +-
>   drivers/ata/pata_sc1200.c               |  2 +-
>   drivers/ata/pata_sch.c                  |  2 +-
>   drivers/ata/pata_serverworks.c          |  6 +++---
>   drivers/ata/pata_sil680.c               |  2 +-
>   drivers/ata/pata_sis.c                  |  2 +-
>   drivers/ata/pata_sl82c105.c             |  2 +-
>   drivers/ata/pata_triflex.c              |  2 +-
>   drivers/ata/pata_via.c                  |  2 +-
>   drivers/ata/pdc_adma.c                  |  2 +-
>   drivers/ata/sata_dwc_460ex.c            |  2 +-
>   drivers/ata/sata_fsl.c                  |  2 +-
>   drivers/ata/sata_highbank.c             |  2 +-
>   drivers/ata/sata_inic162x.c             |  2 +-
>   drivers/ata/sata_mv.c                   |  4 ++--
>   drivers/ata/sata_nv.c                   |  8 ++++----
>   drivers/ata/sata_promise.c              |  2 +-
>   drivers/ata/sata_qstor.c                |  2 +-
>   drivers/ata/sata_rcar.c                 |  2 +-
>   drivers/ata/sata_sil.c                  |  2 +-
>   drivers/ata/sata_sil24.c                |  2 +-
>   drivers/ata/sata_sis.c                  |  2 +-
>   drivers/ata/sata_svw.c                  |  2 +-
>   drivers/ata/sata_sx4.c                  |  2 +-
>   drivers/ata/sata_uli.c                  |  2 +-
>   drivers/ata/sata_via.c                  |  2 +-
>   drivers/ata/sata_vsc.c                  |  2 +-
>   include/linux/ahci_platform.h           |  2 +-
>   include/linux/ata_platform.h            |  2 +-
>   include/linux/libata.h                  | 10 +++++-----
>   111 files changed, 129 insertions(+), 129 deletions(-)

...

> diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
> index 4fb94db1217d..8e5e2b359f2d 100644
> --- a/drivers/ata/ahci_tegra.c
> +++ b/drivers/ata/ahci_tegra.c
> @@ -506,7 +506,7 @@ static const struct of_device_id tegra_ahci_of_match[] = {
>   };
>   MODULE_DEVICE_TABLE(of, tegra_ahci_of_match);
>   
> -static struct scsi_host_template ahci_platform_sht = {
> +static const struct scsi_host_template ahci_platform_sht = {
>   	AHCI_SHT(DRV_NAME),
>   };


For Tegra ...

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

-- 
nvpublic

  parent reply	other threads:[~2023-03-10 15:03 UTC|newest]

Thread overview: 95+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09 19:24 [PATCH v2 00/82] Constify most SCSI host templates Bart Van Assche
2023-03-09 19:24 ` [PATCH v2 01/82] scsi: qla2xxx: Refer directly to the qla2xxx_driver_template Bart Van Assche
2023-03-09 19:24 ` [PATCH v2 02/82] scsi: core: Declare most SCSI host template pointers const Bart Van Assche
2023-03-09 19:24 ` [PATCH v2 03/82] scsi: core: Declare SCSI host template pointer members const Bart Van Assche
2023-03-10  9:24   ` John Garry
2023-03-09 19:24 ` [PATCH v2 04/82] ata: Declare SCSI host templates const Bart Van Assche
2023-03-09 23:36   ` Serge Semin
2023-03-10  9:17   ` John Garry
2023-03-10 14:54   ` Jon Hunter [this message]
2023-03-09 19:24 ` [PATCH v2 05/82] firewire: sbp2: Declare the SCSI host template const Bart Van Assche
2023-03-09 19:24 ` [PATCH v2 06/82] RDMA/srp: " Bart Van Assche
2023-03-13 13:03   ` Leon Romanovsky
2023-03-09 19:24 ` [PATCH v2 07/82] scsi: message: fusion: Declare SCSI host template members const Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 08/82] scsi: zfcp: Declare SCSI host template const Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 09/82] scsi: 3w-9xxx: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 10/82] scsi: 3w-sas: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 11/82] scsi: 3w-xxxx: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 12/82] scsi: BusLogic: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 13/82] scsi: a100u2w: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 14/82] scsi: a2091: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 15/82] scsi: a3000: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 16/82] scsi: aacraid: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 17/82] scsi: advansys: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 18/82] scsi: aha152x: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 19/82] scsi: aha1542: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 20/82] scsi: aic94xx: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 21/82] scsi: arcmsr: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 22/82] scsi: acornscsi: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 23/82] scsi: arxescsi: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 24/82] scsi: aha1740: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 25/82] scsi: cumana: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 26/82] scsi: eesox: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 27/82] scsi: oak: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 28/82] scsi: powertec: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 29/82] scsi: atp870u: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 30/82] scsi: dc395x: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 31/82] scsi: dmx3191d: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 32/82] scsi: elx: efct: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 33/82] scsi: esas2r: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 34/82] scsi: esp_scsi: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 35/82] scsi: fcoe: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 36/82] scsi: fnic: Declare " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 37/82] scsi: qedf: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 38/82] scsi: fdomain: Declare SCSI " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 39/82] scsi: NCR5380: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 40/82] scsi: gvp11: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 41/82] scsi: hisi_sas: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 42/82] scsi: hpsa: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 43/82] scsi: hptiop: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 44/82] scsi: ibmvfc: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 45/82] scsi: imm: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 46/82] scsi: initio: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 47/82] scsi: ipr: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 48/82] scsi: isci: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 49/82] scsi: iscsi: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 50/82] scsi: mac53c94: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 51/82] scsi: mac_scsi: " Bart Van Assche
2023-03-10  4:46   ` Finn Thain
2023-03-10  6:09     ` Michael Schmitz
2023-03-10 18:28       ` Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 52/82] scsi: megaraid: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 53/82] scsi: mesh: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 54/82] scsi: mpi3mr: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 55/82] scsi: mpt3sas: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 56/82] scsi: mvme147: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 57/82] scsi: mvsas: " Bart Van Assche
2023-03-10  9:17   ` John Garry
2023-03-09 19:25 ` [PATCH v2 58/82] scsi: mvumi: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 59/82] scsi: myrb: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 60/82] scsi: myrs: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 61/82] scsi: nsp32: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 62/82] scsi: pcmcia-sym53c500: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 63/82] scsi: pcmcia-pm8001: " Bart Van Assche
2023-03-10  6:31   ` Jinpu Wang
2023-03-09 19:25 ` [PATCH v2 64/82] scsi: pmcraid: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 65/82] scsi: ppa: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 66/82] scsi: ps3rom: " Bart Van Assche
2023-03-09 19:25 ` [PATCH v2 67/82] scsi: qla1280: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 68/82] scsi: qla2xxx: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 69/82] scsi: qlogicpti: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 70/82] scsi: sgiwd93: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 71/82] scsi: smartpqi: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 72/82] scsi: snic: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 73/82] scsi: stex: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 74/82] scsi: sym53c8xx: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 75/82] scsi: virtio-scsi: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 76/82] scsi: wd719x: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 77/82] scsi: xen-scsifront: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 78/82] scsi: rts5208: " Bart Van Assche
2023-03-10  7:32   ` Greg Kroah-Hartman
2023-03-09 19:26 ` [PATCH v2 79/82] scsi: target: tcm-loop: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 80/82] scsi: ufs: " Bart Van Assche
2023-03-09 19:26 ` [PATCH v2 81/82] usb: uas: Declare two host templates and host template pointers const Bart Van Assche
2023-03-10  7:13   ` Greg Kroah-Hartman
2023-03-09 19:26 ` [PATCH v2 82/82] scsi: core: Update a source code comment Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=709a7ebf-22d8-7349-d852-9324eb61e3cb@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=fancer.lancer@gmail.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=hdegoede@redhat.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=john.g.garry@oracle.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@zary.sk \
    --cc=martin.petersen@oracle.com \
    --cc=matthias.bgg@gmail.com \
    --cc=michael.christie@oracle.com \
    --cc=mikpelinux@gmail.com \
    --cc=ming.lei@redhat.com \
    --cc=patrice.chotard@foss.st.com \
    --cc=s.hauer@pengutronix.de \
    --cc=s.shtylyov@omp.ru \
    --cc=samuel@sholland.org \
    --cc=shawnguo@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=vireshk@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox