From: John Garry <john.g.garry@oracle.com>
To: jejb@linux.ibm.com, martin.petersen@oracle.com, dgilbert@interlog.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
bvanassche@acm.org, John Garry <john.g.garry@oracle.com>,
kernel test robot <oliver.sang@intel.com>
Subject: [PATCH v3 01/11] scsi: scsi_debug: Fix check for sdev queue full
Date: Mon, 27 Mar 2023 07:43:00 +0000 [thread overview]
Message-ID: <20230327074310.1862889-2-john.g.garry@oracle.com> (raw)
In-Reply-To: <20230327074310.1862889-1-john.g.garry@oracle.com>
There is a report that the blktests scsi/004 test for "TASK SET FULL" (TSF)
now fails.
The condition upon we should issue this TSF is when the sdev queue is
full. The check for a full queue has an off-by-1 error. Previously we
would increment the number of requests in the queue after testing if the
queue would be full, i.e. test if one less than full. Since we now use
scsi_device_busy() to count the number of requests in the queue, this
would already account for the current request, so fix the test for queue
full accordingly.
Fixes: 151f0ec9ddb5 ("scsi: scsi_debug: Drop sdebug_dev_info.num_in_q")
Reported-by: kernel test robot <oliver.sang@intel.com>
Link: https://lore.kernel.org/oe-lkp/202303201334.18b30edc-oliver.sang@intel.com
Signed-off-by: John Garry <john.g.garry@oracle.com>
---
drivers/scsi/scsi_debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index 7ed117e78bd4..782515abca2c 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -5580,7 +5580,7 @@ static int schedule_resp(struct scsi_cmnd *cmnd, struct sdebug_dev_info *devip,
int num_in_q = scsi_device_busy(sdp);
int qdepth = cmnd->device->queue_depth;
- if ((num_in_q == (qdepth - 1)) &&
+ if ((num_in_q == qdepth) &&
(atomic_inc_return(&sdebug_a_tsf) >=
abs(sdebug_every_nth))) {
atomic_set(&sdebug_a_tsf, 0);
--
2.35.3
next prev parent reply other threads:[~2023-03-27 7:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 7:42 [PATCH v3 00/11] Fix shost command overloading issues John Garry
2023-03-27 7:43 ` John Garry [this message]
2023-03-28 23:35 ` [PATCH v3 01/11] scsi: scsi_debug: Fix check for sdev queue full Douglas Gilbert
2023-03-29 4:20 ` Yi Zhang
2023-03-27 7:43 ` [PATCH v3 02/11] scsi: scsi_debug: Don't iter all shosts in clear_luns_changed_on_target() John Garry
2023-03-28 23:39 ` Douglas Gilbert
2023-03-27 7:43 ` [PATCH v3 03/11] scsi: scsi_debug: Change shost list lock to a mutex John Garry
2023-03-28 23:40 ` Douglas Gilbert
2023-03-27 7:43 ` [PATCH v3 04/11] scsi: scsi_debug: Protect block_unblock_all_queues() with mutex John Garry
2023-04-03 5:11 ` Douglas Gilbert
2023-03-27 7:43 ` [PATCH v3 05/11] scsi: scsi_debug: Use scsi_block_requests() to block queues John Garry
2023-04-03 5:13 ` Douglas Gilbert
2023-03-27 7:43 ` [PATCH v3 06/11] scsi: scsi_debug: Dynamically allocate sdebug_queued_cmd John Garry
2023-04-03 5:18 ` Douglas Gilbert
2023-03-27 7:43 ` [PATCH v3 07/11] scsi: scsi_debug: Use blk_mq_tagset_busy_iter() in sdebug_blk_mq_poll() John Garry
2023-04-03 5:19 ` Douglas Gilbert
2023-03-27 7:43 ` [PATCH v3 08/11] scsi: scsi_debug: Use blk_mq_tagset_busy_iter() in stop_all_queued() John Garry
2023-04-03 5:20 ` Douglas Gilbert
2023-03-27 7:43 ` [PATCH v3 09/11] scsi: scsi_debug: Use scsi_host_busy() in delay_store() and ndelay_store() John Garry
2023-04-03 5:21 ` Douglas Gilbert
2023-03-27 7:43 ` [PATCH v3 10/11] scsi: scsi_debug: Only allow sdebug_max_queue be modified when no shosts John Garry
2023-04-03 5:23 ` Douglas Gilbert
2023-03-27 7:43 ` [PATCH v3 11/11] scsi: scsi_debug: Drop sdebug_queue John Garry
2023-04-03 5:26 ` Douglas Gilbert
2023-04-03 2:15 ` [PATCH v3 00/11] Fix shost command overloading issues Martin K. Petersen
2023-04-12 2:04 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230327074310.1862889-2-john.g.garry@oracle.com \
--to=john.g.garry@oracle.com \
--cc=bvanassche@acm.org \
--cc=dgilbert@interlog.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=oliver.sang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox