* [PATCH] scsi: target: core: remove unused prod_len variable
@ 2023-03-29 13:24 Tom Rix
2023-03-29 21:07 ` Chaitanya Kulkarni
2023-04-12 2:04 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2023-03-29 13:24 UTC (permalink / raw)
To: martin.petersen, nathan, ndesaulniers
Cc: linux-scsi, target-devel, linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/target/target_core_spc.c:229:6: error: variable
'prod_len' set but not used [-Werror,-Wunused-but-set-variable]
u32 prod_len;
^
This variable is not used so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/target/target_core_spc.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/target/target_core_spc.c b/drivers/target/target_core_spc.c
index 5bae45c3fb65..89c0d56294cc 100644
--- a/drivers/target/target_core_spc.c
+++ b/drivers/target/target_core_spc.c
@@ -226,7 +226,6 @@ spc_emulate_evpd_83(struct se_cmd *cmd, unsigned char *buf)
struct t10_alua_lu_gp_member *lu_gp_mem;
struct t10_alua_tg_pt_gp *tg_pt_gp;
unsigned char *prod = &dev->t10_wwn.model[0];
- u32 prod_len;
u32 off = 0;
u16 len = 0, id_len;
@@ -267,10 +266,6 @@ spc_emulate_evpd_83(struct se_cmd *cmd, unsigned char *buf)
* T10 Vendor Identifier Page, see spc4r17 section 7.7.3.4
*/
id_len = 8; /* For Vendor field */
- prod_len = 4; /* For VPD Header */
- prod_len += 8; /* For Vendor field */
- prod_len += strlen(prod);
- prod_len++; /* For : */
if (dev->dev_flags & DF_EMULATED_VPD_UNIT_SERIAL)
id_len += sprintf(&buf[off+12], "%s:%s", prod,
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: target: core: remove unused prod_len variable
2023-03-29 13:24 [PATCH] scsi: target: core: remove unused prod_len variable Tom Rix
@ 2023-03-29 21:07 ` Chaitanya Kulkarni
2023-04-12 2:04 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2023-03-29 21:07 UTC (permalink / raw)
To: Tom Rix, martin.petersen@oracle.com, nathan@kernel.org,
ndesaulniers@google.com
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
On 3/29/23 06:24, Tom Rix wrote:
> clang with W=1 reports
> drivers/target/target_core_spc.c:229:6: error: variable
> 'prod_len' set but not used [-Werror,-Wunused-but-set-variable]
> u32 prod_len;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: target: core: remove unused prod_len variable
2023-03-29 13:24 [PATCH] scsi: target: core: remove unused prod_len variable Tom Rix
2023-03-29 21:07 ` Chaitanya Kulkarni
@ 2023-04-12 2:04 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2023-04-12 2:04 UTC (permalink / raw)
To: nathan, ndesaulniers, Tom Rix
Cc: Martin K . Petersen, linux-scsi, target-devel, linux-kernel, llvm
On Wed, 29 Mar 2023 09:24:21 -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/target/target_core_spc.c:229:6: error: variable
> 'prod_len' set but not used [-Werror,-Wunused-but-set-variable]
> u32 prod_len;
> ^
> This variable is not used so remove it.
>
> [...]
Applied to 6.4/scsi-queue, thanks!
[1/1] scsi: target: core: remove unused prod_len variable
https://git.kernel.org/mkp/scsi/c/aa4d7812cf2c
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-12 2:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-29 13:24 [PATCH] scsi: target: core: remove unused prod_len variable Tom Rix
2023-03-29 21:07 ` Chaitanya Kulkarni
2023-04-12 2:04 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox