* [PATCH] scsi: qedf: remove unused num_handled variable
@ 2023-03-30 20:34 Tom Rix
2023-04-03 1:45 ` Martin K. Petersen
2023-04-12 2:04 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2023-03-30 20:34 UTC (permalink / raw)
To: skashyap, jhasan, jejb, martin.petersen, nathan, ndesaulniers
Cc: GR-QLogic-Storage-Upstream, linux-scsi, linux-kernel, llvm,
Tom Rix
clang with W=1 reports
drivers/scsi/qedf/qedf_main.c:2227:6: error: variable
'num_handled' set but not used [-Werror,-Wunused-but-set-variable]
int num_handled = 0;
^
This variable is not used so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/scsi/qedf/qedf_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index e7f2560b9f7d..3b64de81ea0d 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -2224,7 +2224,6 @@ static bool qedf_process_completions(struct qedf_fastpath *fp)
u16 prod_idx;
struct fcoe_cqe *cqe;
struct qedf_io_work *io_work;
- int num_handled = 0;
unsigned int cpu;
struct qedf_ioreq *io_req = NULL;
u16 xid;
@@ -2247,7 +2246,6 @@ static bool qedf_process_completions(struct qedf_fastpath *fp)
while (new_cqes) {
fp->completions++;
- num_handled++;
cqe = &que->cq[que->cq_cons_idx];
comp_type = (cqe->cqe_data >> FCOE_CQE_CQE_TYPE_SHIFT) &
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: qedf: remove unused num_handled variable
2023-03-30 20:34 [PATCH] scsi: qedf: remove unused num_handled variable Tom Rix
@ 2023-04-03 1:45 ` Martin K. Petersen
2023-04-12 2:04 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2023-04-03 1:45 UTC (permalink / raw)
To: Tom Rix
Cc: skashyap, jhasan, jejb, martin.petersen, nathan, ndesaulniers,
GR-QLogic-Storage-Upstream, linux-scsi, linux-kernel, llvm
Tom,
> clang with W=1 reports
> drivers/scsi/qedf/qedf_main.c:2227:6: error: variable
> 'num_handled' set but not used [-Werror,-Wunused-but-set-variable]
> int num_handled = 0;
> ^
> This variable is not used so remove it.
Applied to 6.4/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qedf: remove unused num_handled variable
2023-03-30 20:34 [PATCH] scsi: qedf: remove unused num_handled variable Tom Rix
2023-04-03 1:45 ` Martin K. Petersen
@ 2023-04-12 2:04 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2023-04-12 2:04 UTC (permalink / raw)
To: skashyap, jhasan, jejb, nathan, ndesaulniers, Tom Rix
Cc: Martin K . Petersen, GR-QLogic-Storage-Upstream, linux-scsi,
linux-kernel, llvm
On Thu, 30 Mar 2023 16:34:44 -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/scsi/qedf/qedf_main.c:2227:6: error: variable
> 'num_handled' set but not used [-Werror,-Wunused-but-set-variable]
> int num_handled = 0;
> ^
> This variable is not used so remove it.
>
> [...]
Applied to 6.4/scsi-queue, thanks!
[1/1] scsi: qedf: remove unused num_handled variable
https://git.kernel.org/mkp/scsi/c/7866e03b9825
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-12 2:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-30 20:34 [PATCH] scsi: qedf: remove unused num_handled variable Tom Rix
2023-04-03 1:45 ` Martin K. Petersen
2023-04-12 2:04 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox