From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH] aic79xx: fix up NULL command in ahd_done()
Date: Tue, 24 Oct 2023 08:24:56 +0200 [thread overview]
Message-ID: <20231024062456.GC8258@lst.de> (raw)
In-Reply-To: <20231023073014.21438-1-hare@suse.de>
On Mon, Oct 23, 2023 at 09:30:14AM +0200, Hannes Reinecke wrote:
> +++ b/drivers/scsi/aic7xxx/aic79xx_osm.c
> @@ -1834,7 +1834,7 @@ ahd_done(struct ahd_softc *ahd, struct scb *scb)
> } else {
> ahd_set_transaction_status(scb, CAM_REQ_CMP);
> }
> - } else if (ahd_get_transaction_status(scb) == CAM_SCSI_STATUS_ERROR) {
> + } else if (cmd && ahd_get_transaction_status(scb) == CAM_SCSI_STATUS_ERROR) {
Please avoid the overly long line here.
Otherwise looks good.
next prev parent reply other threads:[~2023-10-24 6:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 7:30 [PATCH] aic79xx: fix up NULL command in ahd_done() Hannes Reinecke
2023-10-24 6:24 ` Christoph Hellwig [this message]
2023-10-25 2:38 ` Martin K. Petersen
2023-10-30 15:34 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024062456.GC8258@lst.de \
--to=hch@lst.de \
--cc=dan.carpenter@linaro.org \
--cc=hare@suse.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox