* [PATCH] aic79xx: fix up NULL command in ahd_done()
@ 2023-10-23 7:30 Hannes Reinecke
2023-10-24 6:24 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Hannes Reinecke @ 2023-10-23 7:30 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Christoph Hellwig, James Bottomley, linux-scsi, Hannes Reinecke,
Dan Carpenter
Found by smatch.
Fixes: c67e63800446 ("scsi: aic79xx: Do not reference SCSI command when resetting device")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/scsi/aic7xxx/aic79xx_osm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/drivers/scsi/aic7xxx/aic79xx_osm.c
index b3075a022d99..77c91a405d20 100644
--- a/drivers/scsi/aic7xxx/aic79xx_osm.c
+++ b/drivers/scsi/aic7xxx/aic79xx_osm.c
@@ -1834,7 +1834,7 @@ ahd_done(struct ahd_softc *ahd, struct scb *scb)
} else {
ahd_set_transaction_status(scb, CAM_REQ_CMP);
}
- } else if (ahd_get_transaction_status(scb) == CAM_SCSI_STATUS_ERROR) {
+ } else if (cmd && ahd_get_transaction_status(scb) == CAM_SCSI_STATUS_ERROR) {
ahd_linux_handle_scsi_status(ahd, cmd->device, scb);
}
@@ -1868,7 +1868,8 @@ ahd_done(struct ahd_softc *ahd, struct scb *scb)
}
ahd_free_scb(ahd, scb);
- ahd_linux_queue_cmd_complete(ahd, cmd);
+ if (cmd)
+ ahd_linux_queue_cmd_complete(ahd, cmd);
}
static void
--
2.35.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] aic79xx: fix up NULL command in ahd_done()
2023-10-23 7:30 [PATCH] aic79xx: fix up NULL command in ahd_done() Hannes Reinecke
@ 2023-10-24 6:24 ` Christoph Hellwig
2023-10-25 2:38 ` Martin K. Petersen
2023-10-30 15:34 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2023-10-24 6:24 UTC (permalink / raw)
To: Hannes Reinecke
Cc: Martin K. Petersen, Christoph Hellwig, James Bottomley,
linux-scsi, Dan Carpenter
On Mon, Oct 23, 2023 at 09:30:14AM +0200, Hannes Reinecke wrote:
> +++ b/drivers/scsi/aic7xxx/aic79xx_osm.c
> @@ -1834,7 +1834,7 @@ ahd_done(struct ahd_softc *ahd, struct scb *scb)
> } else {
> ahd_set_transaction_status(scb, CAM_REQ_CMP);
> }
> - } else if (ahd_get_transaction_status(scb) == CAM_SCSI_STATUS_ERROR) {
> + } else if (cmd && ahd_get_transaction_status(scb) == CAM_SCSI_STATUS_ERROR) {
Please avoid the overly long line here.
Otherwise looks good.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] aic79xx: fix up NULL command in ahd_done()
2023-10-23 7:30 [PATCH] aic79xx: fix up NULL command in ahd_done() Hannes Reinecke
2023-10-24 6:24 ` Christoph Hellwig
@ 2023-10-25 2:38 ` Martin K. Petersen
2023-10-30 15:34 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2023-10-25 2:38 UTC (permalink / raw)
To: Hannes Reinecke
Cc: Martin K. Petersen, Christoph Hellwig, James Bottomley,
linux-scsi, Dan Carpenter
Hannes,
> Found by smatch.
Applied to 6.7/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] aic79xx: fix up NULL command in ahd_done()
2023-10-23 7:30 [PATCH] aic79xx: fix up NULL command in ahd_done() Hannes Reinecke
2023-10-24 6:24 ` Christoph Hellwig
2023-10-25 2:38 ` Martin K. Petersen
@ 2023-10-30 15:34 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2023-10-30 15:34 UTC (permalink / raw)
To: Hannes Reinecke
Cc: Martin K . Petersen, Christoph Hellwig, James Bottomley,
linux-scsi, Dan Carpenter
On Mon, 23 Oct 2023 09:30:14 +0200, Hannes Reinecke wrote:
> Found by smatch.
>
>
Applied to 6.7/scsi-queue, thanks!
[1/1] aic79xx: fix up NULL command in ahd_done()
https://git.kernel.org/mkp/scsi/c/c7f4c5dec651
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-30 15:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-23 7:30 [PATCH] aic79xx: fix up NULL command in ahd_done() Hannes Reinecke
2023-10-24 6:24 ` Christoph Hellwig
2023-10-25 2:38 ` Martin K. Petersen
2023-10-30 15:34 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox