public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Damien Le Moal <dlemoal@kernel.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
	virtualization@lists.linux.dev, linux-nvme@lists.infradead.org,
	linux-scsi@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Subject: [PATCH 5/5] sd: only call disk_clear_zoned when needed
Date: Sun, 17 Dec 2023 17:53:59 +0100	[thread overview]
Message-ID: <20231217165359.604246-6-hch@lst.de> (raw)
In-Reply-To: <20231217165359.604246-1-hch@lst.de>

disk_clear_zoned only needs to be called when a device reported zone
managed mode first and we clear it.  Add a check so that disk_clear_zoned
isn't called on devices that were never zoned.

This avoids a fairly expensive queue freezing when revalidating
conventional devices.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/scsi/sd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index dbed075cdb981a..8c8ac5cd1833b4 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -3149,7 +3149,7 @@ static void sd_read_block_characteristics(struct scsi_disk *sdkp)
 		 * the device physical block size.
 		 */
 		blk_queue_zone_write_granularity(q, sdkp->physical_block_size);
-	} else {
+	} else if (blk_queue_is_zoned(q)) {
 		/*
 		 * Anything else.  This includes host-aware device that we treat
 		 * as conventional.
-- 
2.39.2


  parent reply	other threads:[~2023-12-17 16:54 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-17 16:53 remove support for the host aware zoned model Christoph Hellwig
2023-12-17 16:53 ` [PATCH 1/5] virtio_blk: cleanup zoned device probing Christoph Hellwig
2023-12-18  9:35   ` Damien Le Moal
2023-12-18 15:13   ` Stefan Hajnoczi
2024-01-16 19:02   ` [f2fs-dev] " patchwork-bot+f2fs
2023-12-17 16:53 ` [PATCH 2/5] virtio_blk: remove the broken zone revalidation support Christoph Hellwig
2023-12-18  9:37   ` Damien Le Moal
2023-12-18 15:15   ` Stefan Hajnoczi
2023-12-17 16:53 ` [PATCH 3/5] block: remove support for the host aware zone model Christoph Hellwig
2023-12-18  6:15   ` Ed Tsai (蔡宗軒)
2023-12-18  6:53     ` Damien Le Moal
2023-12-18  8:21       ` Ed Tsai (蔡宗軒)
2023-12-18  9:33         ` Damien Le Moal
2023-12-19  7:16         ` Naohiro Aota
2023-12-19  8:08           ` Ed Tsai (蔡宗軒)
2023-12-19  8:12             ` Damien Le Moal
2023-12-19 10:38               ` hch
2023-12-19 12:16                 ` hch
2023-12-18  9:48   ` Damien Le Moal
2023-12-18 14:33     ` Christoph Hellwig
2023-12-17 16:53 ` [PATCH 4/5] block: simplify disk_set_zoned Christoph Hellwig
2023-12-18  9:50   ` Damien Le Moal
2023-12-17 16:53 ` Christoph Hellwig [this message]
2023-12-18  9:51   ` [PATCH 5/5] sd: only call disk_clear_zoned when needed Damien Le Moal
2023-12-19  2:16 ` remove support for the host aware zoned model Martin K. Petersen
2023-12-20  3:18 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231217165359.604246-6-hch@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=dlemoal@kernel.org \
    --cc=dm-devel@lists.linux.dev \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=pbonzini@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox