From: "hch@lst.de" <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: "Ed Tsai (蔡宗軒)" <Ed.Tsai@mediatek.com>,
"Naohiro.Aota@wdc.com" <Naohiro.Aota@wdc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux.dev" <virtualization@lists.linux.dev>,
"hch@lst.de" <hch@lst.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"Chun-Hung Wu (巫駿宏)" <Chun-hung.Wu@mediatek.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"dm-devel@lists.linux.dev" <dm-devel@lists.linux.dev>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"linux-f2fs-devel@lists.sourceforge.net"
<linux-f2fs-devel@lists.sourceforge.net>,
"stefanha@redhat.com" <stefanha@redhat.com>
Subject: Re: [PATCH 3/5] block: remove support for the host aware zone model
Date: Tue, 19 Dec 2023 11:38:25 +0100 [thread overview]
Message-ID: <20231219103825.GB14379@lst.de> (raw)
In-Reply-To: <0a329050-0010-47cb-8c7b-a2f0863a21e8@kernel.org>
On Tue, Dec 19, 2023 at 05:12:41PM +0900, Damien Le Moal wrote:
> >> Since we cannot create lambda as in other fancy languages, we need
> >> two
> >> functions...
> >
> > Not really, there is a "void *data" can be used.
> >
> > The device_is_zoned_model() is just the same as the device_not_zoned()
> > with (bool *)data = false.
> >
> > It's very minor, so is okay to ignore my preference.
>
> Send a patch on top of Christoph's series if you want to clean this up.
I'll need to respin anyway, so I'll look into incorporating the
suggestion.
next prev parent reply other threads:[~2023-12-19 10:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-17 16:53 remove support for the host aware zoned model Christoph Hellwig
2023-12-17 16:53 ` [PATCH 1/5] virtio_blk: cleanup zoned device probing Christoph Hellwig
2023-12-18 9:35 ` Damien Le Moal
2023-12-18 15:13 ` Stefan Hajnoczi
2024-01-16 19:02 ` [f2fs-dev] " patchwork-bot+f2fs
2023-12-17 16:53 ` [PATCH 2/5] virtio_blk: remove the broken zone revalidation support Christoph Hellwig
2023-12-18 9:37 ` Damien Le Moal
2023-12-18 15:15 ` Stefan Hajnoczi
2023-12-17 16:53 ` [PATCH 3/5] block: remove support for the host aware zone model Christoph Hellwig
2023-12-18 6:15 ` Ed Tsai (蔡宗軒)
2023-12-18 6:53 ` Damien Le Moal
2023-12-18 8:21 ` Ed Tsai (蔡宗軒)
2023-12-18 9:33 ` Damien Le Moal
2023-12-19 7:16 ` Naohiro Aota
2023-12-19 8:08 ` Ed Tsai (蔡宗軒)
2023-12-19 8:12 ` Damien Le Moal
2023-12-19 10:38 ` hch [this message]
2023-12-19 12:16 ` hch
2023-12-18 9:48 ` Damien Le Moal
2023-12-18 14:33 ` Christoph Hellwig
2023-12-17 16:53 ` [PATCH 4/5] block: simplify disk_set_zoned Christoph Hellwig
2023-12-18 9:50 ` Damien Le Moal
2023-12-17 16:53 ` [PATCH 5/5] sd: only call disk_clear_zoned when needed Christoph Hellwig
2023-12-18 9:51 ` Damien Le Moal
2023-12-19 2:16 ` remove support for the host aware zoned model Martin K. Petersen
2023-12-20 3:18 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231219103825.GB14379@lst.de \
--to=hch@lst.de \
--cc=Chun-hung.Wu@mediatek.com \
--cc=Ed.Tsai@mediatek.com \
--cc=Naohiro.Aota@wdc.com \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox