From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Damien Le Moal <damien.lemoal@wdc.com>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: [PATCH 1/2] sd: remove the !ZBC && blk_queue_is_zoned case in sd_read_block_characteristics
Date: Thu, 28 Dec 2023 07:51:40 +0000 [thread overview]
Message-ID: <20231228075141.362560-2-hch@lst.de> (raw)
In-Reply-To: <20231228075141.362560-1-hch@lst.de>
Now that host-aware devices are always treated as conventional this case
can't happen.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/scsi/sd.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 6bedd2d5298f6d..dace4aa8e3534d 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -3149,12 +3149,11 @@ static void sd_read_block_characteristics(struct scsi_disk *sdkp)
* the device physical block size.
*/
blk_queue_zone_write_granularity(q, sdkp->physical_block_size);
- } else if (blk_queue_is_zoned(q)) {
+ } else {
/*
- * Anything else. This includes host-aware device that we treat
- * as conventional.
+ * Host-aware devices are treated as conventional.
*/
- disk_clear_zoned(sdkp->disk);
+ WARN_ON_ONCE(blk_queue_is_zoned(q));
}
#endif /* CONFIG_BLK_DEV_ZONED */
--
2.39.2
next prev parent reply other threads:[~2023-12-28 7:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 7:51 remove another host aware model leftover Christoph Hellwig
2023-12-28 7:51 ` Christoph Hellwig [this message]
2024-01-08 8:48 ` [PATCH 1/2] sd: remove the !ZBC && blk_queue_is_zoned case in sd_read_block_characteristics Hannes Reinecke
2023-12-28 7:51 ` [PATCH 2/2] block: remove disk_clear_zoned Christoph Hellwig
2024-01-08 8:48 ` Hannes Reinecke
2023-12-28 8:45 ` remove another host aware model leftover Damien Le Moal
2023-12-28 17:14 ` Christoph Hellwig
2024-01-03 0:02 ` Damien Le Moal
2024-01-08 8:24 ` Christoph Hellwig
2024-01-08 15:26 ` Jens Axboe
2024-01-08 16:14 ` Martin K. Petersen
2024-01-08 19:16 ` Jens Axboe
2024-01-08 15:27 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231228075141.362560-2-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox