From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Damien Le Moal <damien.lemoal@wdc.com>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: remove another host aware model leftover
Date: Thu, 28 Dec 2023 18:14:45 +0100 [thread overview]
Message-ID: <20231228171445.GA25852@lst.de> (raw)
In-Reply-To: <6933c048-f77b-4645-a667-adae0f89b347@kernel.org>
On Thu, Dec 28, 2023 at 05:45:29PM +0900, Damien Le Moal wrote:
> On 12/28/23 16:51, Christoph Hellwig wrote:
> > Hi all,
> >
> > now that support for the host aware zoned model is gone in the
> > for-6.8/block branch, there is no way the sd driver can find a device
> > where is has to clear the zoned flag, and we can thus remove the code
> > for it, including a block layer helper.
>
> Hmmm... There is one case: if the user uses a passthrough command to issue a
> FORMAT WITH PRESET command to reformat the disk from SMR to CMR or from CMR to
> SMR. The next revalidate will see a different device type in this case, and
> SMR-to-CMR reformat will need clearing the zoned stuff.
scsi_device.type is only set in scsi_add_lun and thus can't change without
a re-probe of the upper level driver.
next prev parent reply other threads:[~2023-12-28 17:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 7:51 remove another host aware model leftover Christoph Hellwig
2023-12-28 7:51 ` [PATCH 1/2] sd: remove the !ZBC && blk_queue_is_zoned case in sd_read_block_characteristics Christoph Hellwig
2024-01-08 8:48 ` Hannes Reinecke
2023-12-28 7:51 ` [PATCH 2/2] block: remove disk_clear_zoned Christoph Hellwig
2024-01-08 8:48 ` Hannes Reinecke
2023-12-28 8:45 ` remove another host aware model leftover Damien Le Moal
2023-12-28 17:14 ` Christoph Hellwig [this message]
2024-01-03 0:02 ` Damien Le Moal
2024-01-08 8:24 ` Christoph Hellwig
2024-01-08 15:26 ` Jens Axboe
2024-01-08 16:14 ` Martin K. Petersen
2024-01-08 19:16 ` Jens Axboe
2024-01-08 15:27 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231228171445.GA25852@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox