* [PATCH] scsi: ufs: qcom: update MODE_MAX cfg_bw value
@ 2024-08-28 12:05 Manish Pandey
2024-08-28 12:15 ` Bart Van Assche
2024-08-28 13:15 ` Manivannan Sadhasivam
0 siblings, 2 replies; 4+ messages in thread
From: Manish Pandey @ 2024-08-28 12:05 UTC (permalink / raw)
To: Manivannan Sadhasivam, James E.J. Bottomley, Martin K. Petersen
Cc: linux-arm-msm, linux-scsi, linux-kernel, quic_nitirawa,
quic_bhaskarv, quic_narepall, quic_rampraka, quic_mapa, quic_cang,
quic_nguyenb
update cfg_bw value for MODE_MAX for Qualcomm SoC.
Signed-off-by: Manish Pandey <quic_mapa@quicinc.com>
---
drivers/ufs/host/ufs-qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index c87fdc849c62..ecdfff2456e3 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -93,7 +93,7 @@ static const struct __ufs_qcom_bw_table {
[MODE_HS_RB][UFS_HS_G3][UFS_LANE_2] = { 1492582, 204800 },
[MODE_HS_RB][UFS_HS_G4][UFS_LANE_2] = { 2915200, 409600 },
[MODE_HS_RB][UFS_HS_G5][UFS_LANE_2] = { 5836800, 819200 },
- [MODE_MAX][0][0] = { 7643136, 307200 },
+ [MODE_MAX][0][0] = { 7643136, 819200 },
};
static void ufs_qcom_get_default_testbus_cfg(struct ufs_qcom_host *host);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: ufs: qcom: update MODE_MAX cfg_bw value
2024-08-28 12:05 [PATCH] scsi: ufs: qcom: update MODE_MAX cfg_bw value Manish Pandey
@ 2024-08-28 12:15 ` Bart Van Assche
2024-08-28 13:26 ` MANISH PANDEY
2024-08-28 13:15 ` Manivannan Sadhasivam
1 sibling, 1 reply; 4+ messages in thread
From: Bart Van Assche @ 2024-08-28 12:15 UTC (permalink / raw)
To: Manish Pandey, Manivannan Sadhasivam, James E.J. Bottomley,
Martin K. Petersen
Cc: linux-arm-msm, linux-scsi, linux-kernel, quic_nitirawa,
quic_bhaskarv, quic_narepall, quic_rampraka, quic_cang,
quic_nguyenb
On 8/28/24 8:05 AM, Manish Pandey wrote:
> update cfg_bw value for MODE_MAX for Qualcomm SoC.
A patch description should not only explain what has been changed but
also why.
Thanks,
Bart.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ufs: qcom: update MODE_MAX cfg_bw value
2024-08-28 12:15 ` Bart Van Assche
@ 2024-08-28 13:26 ` MANISH PANDEY
0 siblings, 0 replies; 4+ messages in thread
From: MANISH PANDEY @ 2024-08-28 13:26 UTC (permalink / raw)
To: Bart Van Assche, Manivannan Sadhasivam, James E.J. Bottomley,
Martin K. Petersen
Cc: linux-arm-msm, linux-scsi, linux-kernel, quic_nitirawa,
quic_bhaskarv, quic_narepall, quic_rampraka, quic_cang,
quic_nguyenb
On 8/28/2024 5:45 PM, Bart Van Assche wrote:
> On 8/28/24 8:05 AM, Manish Pandey wrote:
>> update cfg_bw value for MODE_MAX for Qualcomm SoC.
>
> A patch description should not only explain what has been changed but
> also why.
>
> Thanks,
>
> Bart.
I will update in next patch update [V2].
Regards
manish
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ufs: qcom: update MODE_MAX cfg_bw value
2024-08-28 12:05 [PATCH] scsi: ufs: qcom: update MODE_MAX cfg_bw value Manish Pandey
2024-08-28 12:15 ` Bart Van Assche
@ 2024-08-28 13:15 ` Manivannan Sadhasivam
1 sibling, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2024-08-28 13:15 UTC (permalink / raw)
To: Manish Pandey
Cc: James E.J. Bottomley, Martin K. Petersen, linux-arm-msm,
linux-scsi, linux-kernel, quic_nitirawa, quic_bhaskarv,
quic_narepall, quic_rampraka, quic_cang, quic_nguyenb
On Wed, Aug 28, 2024 at 05:35:02PM +0530, Manish Pandey wrote:
> update cfg_bw value for MODE_MAX for Qualcomm SoC.
>
As Bart said, please do not send patches with these vague descriptions. They
provide no info whatsoever to the community on why this patch is needed. There
should be a valid justification to convince the community to accept your patch.
If you are sending a series, this same comment applies to all the patches.
- Mani
> Signed-off-by: Manish Pandey <quic_mapa@quicinc.com>
> ---
> drivers/ufs/host/ufs-qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index c87fdc849c62..ecdfff2456e3 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -93,7 +93,7 @@ static const struct __ufs_qcom_bw_table {
> [MODE_HS_RB][UFS_HS_G3][UFS_LANE_2] = { 1492582, 204800 },
> [MODE_HS_RB][UFS_HS_G4][UFS_LANE_2] = { 2915200, 409600 },
> [MODE_HS_RB][UFS_HS_G5][UFS_LANE_2] = { 5836800, 819200 },
> - [MODE_MAX][0][0] = { 7643136, 307200 },
> + [MODE_MAX][0][0] = { 7643136, 819200 },
> };
>
> static void ufs_qcom_get_default_testbus_cfg(struct ufs_qcom_host *host);
> --
> 2.17.1
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-28 13:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-28 12:05 [PATCH] scsi: ufs: qcom: update MODE_MAX cfg_bw value Manish Pandey
2024-08-28 12:15 ` Bart Van Assche
2024-08-28 13:26 ` MANISH PANDEY
2024-08-28 13:15 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).