From: Manivannan Sadhasivam <manisadhasivam.linux@gmail.com>
To: Avri Altman <avri.altman@wdc.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Bart Van Assche <bvanassche@acm.org>,
Can Guo <cang@qti.qualcomm.com>,
quic_ziqichen@quicinc.com
Subject: Re: [PATCH] scsi: ufs: Move clock gating sysfs entries to ufs-sysfs.c
Date: Wed, 22 Jan 2025 22:42:37 +0530 [thread overview]
Message-ID: <20250122171237.33gvwxgmpsoqekwt@thinkpad> (raw)
In-Reply-To: <20250122143605.3804506-1-avri.altman@wdc.com>
+ Ziqi
On Wed, Jan 22, 2025 at 04:36:05PM +0200, Avri Altman wrote:
> This commit moves the clock gating sysfs entries from `ufshcd.c` to
> `ufs-sysfs.c` where it belongs. This change improves the organization of
> the code by consolidating all sysfs-related code into a single file.
>
> The `clkgate_enable` and `clkgate_delay_ms` attributes are now defined
> and managed in `ufs-sysfs.c`, and the corresponding initialization and
> removal functions in `ufshcd.c` are removed.
>
> No functional change.
>
> Signed-off-by: Avri Altman <avri.altman@wdc.com>
While this patch is useful, you should also consider adding the ABI
documentation for these. I did share the comment to another patch that touches
this part of the code:
https://lore.kernel.org/linux-scsi/20250119074823.lnlppdpsfnkz7onx@thinkpad/
Maybe it is relevant to add the documentation together with this patch.
- Mani
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2025-01-22 17:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 14:36 [PATCH] scsi: ufs: Move clock gating sysfs entries to ufs-sysfs.c Avri Altman
2025-01-22 17:12 ` Manivannan Sadhasivam [this message]
2025-01-22 17:46 ` Avri Altman
2025-01-22 18:39 ` Bart Van Assche
2025-01-23 7:31 ` Avri Altman
2025-01-23 18:37 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250122171237.33gvwxgmpsoqekwt@thinkpad \
--to=manisadhasivam.linux@gmail.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cang@qti.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_ziqichen@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox