From: Bart Van Assche <bvanassche@acm.org>
To: Avri Altman <Avri.Altman@wdc.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Manivannan Sadhasivam <manisadhasivam.linux@gmail.com>,
Can Guo <cang@qti.qualcomm.com>
Subject: Re: [PATCH] scsi: ufs: Move clock gating sysfs entries to ufs-sysfs.c
Date: Thu, 23 Jan 2025 10:37:21 -0800 [thread overview]
Message-ID: <8a714674-fecf-4067-97e4-59e28816c854@acm.org> (raw)
In-Reply-To: <DM6PR04MB657584F352A1AD45FBD7B23DFCE02@DM6PR04MB6575.namprd04.prod.outlook.com>
On 1/22/25 11:31 PM, Avri Altman wrote:
>> On 1/22/25 6:36 AM, Avri Altman wrote:
>>> +static ssize_t
>>> +clkgate_enable_show(struct device *dev, struct device_attribute *attr,
>>> + char *buf)
>>> +{
>>
>> The above formatting does not conform to the Linux kernel coding style.
>> Please fix this, e.g. by running git clang-format HEAD^ && git commit --amend
>> on the git branch with this patch.
> Done.
> AFAIK, there hasn't been a formal announcement that `clang-format` should replace `checkpatch` for Linux kernel development.
> And yes, while checkpatch --strict accepted the above formatting, clang-format did make changes.
Hi Avri,
Nobody ever required to use clang-format as far as I know.
With my email I was referring to the requirement that the return type
and the function name occur on the same line.
Thanks,
Bart.
prev parent reply other threads:[~2025-01-23 18:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 14:36 [PATCH] scsi: ufs: Move clock gating sysfs entries to ufs-sysfs.c Avri Altman
2025-01-22 17:12 ` Manivannan Sadhasivam
2025-01-22 17:46 ` Avri Altman
2025-01-22 18:39 ` Bart Van Assche
2025-01-23 7:31 ` Avri Altman
2025-01-23 18:37 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a714674-fecf-4067-97e4-59e28816c854@acm.org \
--to=bvanassche@acm.org \
--cc=Avri.Altman@wdc.com \
--cc=cang@qti.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manisadhasivam.linux@gmail.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox