public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: linux@treblig.org
To: njavali@marvell.com, GR-QLogic-Storage-Upstream@marvell.com,
	James.Bottomley@HansenPartnership.com,
	martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Dr. David Alan Gilbert" <linux@treblig.org>
Subject: [PATCH 5/8] scsi: qla2xxx: Remove unused qla82xx_wait_for_state_change
Date: Tue, 15 Apr 2025 01:28:00 +0100	[thread overview]
Message-ID: <20250415002803.135909-6-linux@treblig.org> (raw)
In-Reply-To: <20250415002803.135909-1-linux@treblig.org>

From: "Dr. David Alan Gilbert" <linux@treblig.org>

qla82xx_wait_for_state_change() was added in 2010 as part of
commit 579d12b58abb ("[SCSI] qla2xxx: Added support for quiescence mode for
ISP82xx.")
but has remained unused.

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/scsi/qla2xxx/qla_gbl.h |  1 -
 drivers/scsi/qla2xxx/qla_nx.c  | 26 --------------------------
 2 files changed, 27 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_gbl.h b/drivers/scsi/qla2xxx/qla_gbl.h
index ad76cf8e123d..73bccd514791 100644
--- a/drivers/scsi/qla2xxx/qla_gbl.h
+++ b/drivers/scsi/qla2xxx/qla_gbl.h
@@ -865,7 +865,6 @@ extern int qla82xx_rd_32(struct qla_hw_data *, ulong);
 
 /* ISP 8021 IDC */
 extern void qla82xx_clear_drv_active(struct qla_hw_data *);
-extern uint32_t  qla82xx_wait_for_state_change(scsi_qla_host_t *, uint32_t);
 extern int qla82xx_idc_lock(struct qla_hw_data *);
 extern void qla82xx_idc_unlock(struct qla_hw_data *);
 extern int qla82xx_device_state_handler(scsi_qla_host_t *);
diff --git a/drivers/scsi/qla2xxx/qla_nx.c b/drivers/scsi/qla2xxx/qla_nx.c
index 1da954f446f6..78725bda3714 100644
--- a/drivers/scsi/qla2xxx/qla_nx.c
+++ b/drivers/scsi/qla2xxx/qla_nx.c
@@ -2915,32 +2915,6 @@ qla82xx_need_qsnt_handler(scsi_qla_host_t *vha)
 	}
 }
 
-/*
-* qla82xx_wait_for_state_change
-*    Wait for device state to change from given current state
-*
-* Note:
-*     IDC lock must not be held upon entry
-*
-* Return:
-*    Changed device state.
-*/
-uint32_t
-qla82xx_wait_for_state_change(scsi_qla_host_t *vha, uint32_t curr_state)
-{
-	struct qla_hw_data *ha = vha->hw;
-	uint32_t dev_state;
-
-	do {
-		msleep(1000);
-		qla82xx_idc_lock(ha);
-		dev_state = qla82xx_rd_32(ha, QLA82XX_CRB_DEV_STATE);
-		qla82xx_idc_unlock(ha);
-	} while (dev_state == curr_state);
-
-	return dev_state;
-}
-
 void
 qla8xxx_dev_failed_handler(scsi_qla_host_t *vha)
 {
-- 
2.49.0


  parent reply	other threads:[~2025-04-15  0:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-15  0:27 [PATCH 0/8] scsi: qla2xxx deadcoding linux
2025-04-15  0:27 ` [PATCH 1/8] scsi: qla2xxx: Remove unused qlt_free_qfull_cmds linux
2025-04-15  0:27 ` [PATCH 2/8] scsi: qla2xxx: Remove unused qlt_fc_port_deleted linux
2025-04-15  0:27 ` [PATCH 3/8] scsi: qla2xxx: Remove unused qlt_83xx_iospace_config linux
2025-04-15  0:27 ` [PATCH 4/8] scsi: qla2xxx: Remove unused qla82xx_pci_region_offset linux
2025-04-15  0:28 ` linux [this message]
2025-04-15  0:28 ` [PATCH 6/8] scsi: qla2xxx: Remove unused ql_log_qp linux
2025-04-15  0:28 ` [PATCH 7/8] scsi: qla2xxx: Remove unused qla2x00_gpsc linux
2025-04-15  0:28 ` [PATCH 8/8] scsi: qla2xxx: Remove unused module parameters linux
2025-04-22  1:53 ` [PATCH 0/8] scsi: qla2xxx deadcoding Martin K. Petersen
2025-04-29  2:08 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250415002803.135909-6-linux@treblig.org \
    --to=linux@treblig.org \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=njavali@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox