From: linux@treblig.org
To: njavali@marvell.com, GR-QLogic-Storage-Upstream@marvell.com,
James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
"Dr. David Alan Gilbert" <linux@treblig.org>
Subject: [PATCH 6/8] scsi: qla2xxx: Remove unused ql_log_qp
Date: Tue, 15 Apr 2025 01:28:01 +0100 [thread overview]
Message-ID: <20250415002803.135909-7-linux@treblig.org> (raw)
In-Reply-To: <20250415002803.135909-1-linux@treblig.org>
From: "Dr. David Alan Gilbert" <linux@treblig.org>
ql_log_qp() was added in 2017 as part of
commit 22d84726e3b8 ("scsi: qla2xxx: Add debug logging routine for qpair")
but has remained unused.
Remove it.
(That patch also added ql_dbg_qp but that is still used so is left in).
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/scsi/qla2xxx/qla_dbg.c | 53 ----------------------------------
drivers/scsi/qla2xxx/qla_dbg.h | 3 --
2 files changed, 56 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c
index 691ef827a5ab..5136549005e7 100644
--- a/drivers/scsi/qla2xxx/qla_dbg.c
+++ b/drivers/scsi/qla2xxx/qla_dbg.c
@@ -2705,59 +2705,6 @@ ql_dump_buffer(uint level, scsi_qla_host_t *vha, uint id, const void *buf,
}
}
-/*
- * This function is for formatting and logging log messages.
- * It is to be used when vha is available. It formats the message
- * and logs it to the messages file. All the messages will be logged
- * irrespective of value of ql2xextended_error_logging.
- * parameters:
- * level: The level of the log messages to be printed in the
- * messages file.
- * vha: Pointer to the scsi_qla_host_t
- * id: This is a unique id for the level. It identifies the
- * part of the code from where the message originated.
- * msg: The message to be displayed.
- */
-void
-ql_log_qp(uint32_t level, struct qla_qpair *qpair, int32_t id,
- const char *fmt, ...)
-{
- va_list va;
- struct va_format vaf;
- char pbuf[128];
-
- if (level > ql_errlev)
- return;
-
- ql_ktrace(0, level, pbuf, NULL, qpair ? qpair->vha : NULL, id, fmt);
-
- if (!pbuf[0]) /* set by ql_ktrace */
- ql_dbg_prefix(pbuf, ARRAY_SIZE(pbuf), NULL,
- qpair ? qpair->vha : NULL, id);
-
- va_start(va, fmt);
-
- vaf.fmt = fmt;
- vaf.va = &va;
-
- switch (level) {
- case ql_log_fatal: /* FATAL LOG */
- pr_crit("%s%pV", pbuf, &vaf);
- break;
- case ql_log_warn:
- pr_err("%s%pV", pbuf, &vaf);
- break;
- case ql_log_info:
- pr_warn("%s%pV", pbuf, &vaf);
- break;
- default:
- pr_info("%s%pV", pbuf, &vaf);
- break;
- }
-
- va_end(va);
-}
-
/*
* This function is for formatting and logging debug information.
* It is to be used when vha is available. It formats the message
diff --git a/drivers/scsi/qla2xxx/qla_dbg.h b/drivers/scsi/qla2xxx/qla_dbg.h
index 54f0a412226f..5f4a8c9ae6ba 100644
--- a/drivers/scsi/qla2xxx/qla_dbg.h
+++ b/drivers/scsi/qla2xxx/qla_dbg.h
@@ -334,9 +334,6 @@ ql_log(uint, scsi_qla_host_t *vha, uint, const char *fmt, ...);
void __attribute__((format (printf, 4, 5)))
ql_log_pci(uint, struct pci_dev *pdev, uint, const char *fmt, ...);
-void __attribute__((format (printf, 4, 5)))
-ql_log_qp(uint32_t, struct qla_qpair *, int32_t, const char *fmt, ...);
-
/* Debug Levels */
/* The 0x40000000 is the max value any debug level can have
* as ql2xextended_error_logging is of type signed int
--
2.49.0
next prev parent reply other threads:[~2025-04-15 0:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 0:27 [PATCH 0/8] scsi: qla2xxx deadcoding linux
2025-04-15 0:27 ` [PATCH 1/8] scsi: qla2xxx: Remove unused qlt_free_qfull_cmds linux
2025-04-15 0:27 ` [PATCH 2/8] scsi: qla2xxx: Remove unused qlt_fc_port_deleted linux
2025-04-15 0:27 ` [PATCH 3/8] scsi: qla2xxx: Remove unused qlt_83xx_iospace_config linux
2025-04-15 0:27 ` [PATCH 4/8] scsi: qla2xxx: Remove unused qla82xx_pci_region_offset linux
2025-04-15 0:28 ` [PATCH 5/8] scsi: qla2xxx: Remove unused qla82xx_wait_for_state_change linux
2025-04-15 0:28 ` linux [this message]
2025-04-15 0:28 ` [PATCH 7/8] scsi: qla2xxx: Remove unused qla2x00_gpsc linux
2025-04-15 0:28 ` [PATCH 8/8] scsi: qla2xxx: Remove unused module parameters linux
2025-04-22 1:53 ` [PATCH 0/8] scsi: qla2xxx deadcoding Martin K. Petersen
2025-04-29 2:08 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250415002803.135909-7-linux@treblig.org \
--to=linux@treblig.org \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=njavali@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox