public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] mpi3mr: Add logging level check to control event logging
@ 2025-04-15 10:15 Ranjan Kumar
  2025-04-22  1:58 ` Martin K. Petersen
  0 siblings, 1 reply; 2+ messages in thread
From: Ranjan Kumar @ 2025-04-15 10:15 UTC (permalink / raw)
  To: linux-scsi, martin.petersen
  Cc: rajsekhar.chundru, sathya.prakash, sumit.saxena,
	chandrakanth.patil, prayas.patel, Ranjan Kumar

The check ensure event logs are only generated when
the debug logging level "MPI3_DEBUG_EVENT" is enabled.
It prevents unnecessary logging.

Signed-off-by: Ranjan Kumar <ranjan.kumar@broadcom.com>
---
 drivers/scsi/mpi3mr/mpi3mr_fw.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/scsi/mpi3mr/mpi3mr_fw.c b/drivers/scsi/mpi3mr/mpi3mr_fw.c
index 003e1f7005c4..1d7901a8f0e4 100644
--- a/drivers/scsi/mpi3mr/mpi3mr_fw.c
+++ b/drivers/scsi/mpi3mr/mpi3mr_fw.c
@@ -174,6 +174,9 @@ static void mpi3mr_print_event_data(struct mpi3mr_ioc *mrioc,
 	char *desc = NULL;
 	u16 event;
 
+	if (!(mrioc->logging_level & MPI3_DEBUG_EVENT))
+		return;
+
 	event = event_reply->event;
 
 	switch (event) {
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] mpi3mr: Add logging level check to control event logging
  2025-04-15 10:15 [PATCH v1] mpi3mr: Add logging level check to control event logging Ranjan Kumar
@ 2025-04-22  1:58 ` Martin K. Petersen
  0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2025-04-22  1:58 UTC (permalink / raw)
  To: linux-scsi, Ranjan Kumar
  Cc: Martin K . Petersen, rajsekhar.chundru, sathya.prakash,
	sumit.saxena, chandrakanth.patil, prayas.patel

On Tue, 15 Apr 2025 15:45:46 +0530, Ranjan Kumar wrote:

> The check ensure event logs are only generated when
> the debug logging level "MPI3_DEBUG_EVENT" is enabled.
> It prevents unnecessary logging.
> 
> 

Applied to 6.15/scsi-fixes, thanks!

[1/1] mpi3mr: Add logging level check to control event logging
      https://git.kernel.org/mkp/scsi/c/b0b7ee3b574a

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-04-22  1:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-15 10:15 [PATCH v1] mpi3mr: Add logging level check to control event logging Ranjan Kumar
2025-04-22  1:58 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox