From: Damien Le Moal <dlemoal@kernel.org>
To: linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
John Garry <john.g.garry@oracle.com>
Subject: [PATCH v4 2/5] scsi: libsas: Simplify sas_ata_wait_eh()
Date: Fri, 25 Jul 2025 10:58:15 +0900 [thread overview]
Message-ID: <20250725015818.171252-3-dlemoal@kernel.org> (raw)
In-Reply-To: <20250725015818.171252-1-dlemoal@kernel.org>
Simplify the code of sas_ata_wait_eh(), removing the local variable ap
for the pointer to the device ata_port structure. The test using
dev_is_sata() is also removed as all call sites of this function check
if the device is a SATA one before calling this function.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: John Garry <john.g.garry@oracle.com>
---
drivers/scsi/libsas/sas_ata.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
index 7b4e7a61965a..2cbf38b18c5c 100644
--- a/drivers/scsi/libsas/sas_ata.c
+++ b/drivers/scsi/libsas/sas_ata.c
@@ -927,13 +927,7 @@ EXPORT_SYMBOL_GPL(sas_ata_schedule_reset);
void sas_ata_wait_eh(struct domain_device *dev)
{
- struct ata_port *ap;
-
- if (!dev_is_sata(dev))
- return;
-
- ap = dev->sata_dev.ap;
- ata_port_wait_eh(ap);
+ ata_port_wait_eh(dev->sata_dev.ap);
}
void sas_ata_device_link_abort(struct domain_device *device, bool force_reset)
--
2.50.1
next prev parent reply other threads:[~2025-07-25 2:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 1:58 [PATCH v4 0/5] libsas cleanups Damien Le Moal
2025-07-25 1:58 ` [PATCH v4 1/5] scsi: libsas: Refactor dev_is_sata() Damien Le Moal
2025-07-25 6:17 ` Jason Yan
2025-07-25 1:58 ` Damien Le Moal [this message]
2025-07-25 6:20 ` [PATCH v4 2/5] scsi: libsas: Simplify sas_ata_wait_eh() Jason Yan
2025-07-25 1:58 ` [PATCH v4 3/5] scsi: libsas: Make sas_get_ata_info() static Damien Le Moal
2025-07-25 6:22 ` Jason Yan
2025-07-25 1:58 ` [PATCH v4 4/5] scsi: libsas: Move declarations of internal functions to sas_internal.h Damien Le Moal
2025-07-25 6:23 ` Jason Yan
2025-07-25 1:58 ` [PATCH v4 5/5] scsi: libsas: Use a bool for sas_deform_port() second argument Damien Le Moal
2025-07-25 6:24 ` Jason Yan
2025-07-25 13:06 ` [PATCH v4 0/5] libsas cleanups Martin K. Petersen
2025-07-31 4:44 ` Martin K. Petersen
2025-08-06 2:39 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250725015818.171252-3-dlemoal@kernel.org \
--to=dlemoal@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox