Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Chris Leech <cleech@redhat.com>
To: Wang Yan <wangyan01@kylinos.cn>
Cc: lduncan@suse.com, michael.christie@oracle.com,
	 James.Bottomley@hansenpartnership.com,
	martin.petersen@oracle.com, open-iscsi@googlegroups.com,
	 linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: libiscsi: fix spelling and format errors
Date: Mon, 11 May 2026 15:01:48 -0700	[thread overview]
Message-ID: <20260511-resource-blaming-f423310243b5@redhat.com> (raw)
In-Reply-To: <20260511093030.63542-1-wangyan01@kylinos.cn>

On Mon, May 11, 2026 at 05:30:30PM +0800, Wang Yan wrote:
> Fix two issues in libiscsi.c:
> - Correct typo "numer" to "number" in iscsi_session_setup() comment
> - Fix format string "seconds\n." to "seconds.\n" in recv timeout warning
> 
> Signed-off-by: Wang Yan <wangyan01@kylinos.cn>
> ---

Sure, that looks fine.

Reviewed-by: Chris Leech <cleech@redhat.com>

>  drivers/scsi/libiscsi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index 25857d6ed6e8..160f02f2f51d 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -3012,7 +3012,7 @@ static void iscsi_host_dec_session_cnt(struct Scsi_Host *shost)
>   * This can be used by software iscsi_transports that allocate
>   * a session per scsi host.
>   *
> - * Callers should set cmds_max to the largest total numer (mgmt + scsi) of
> + * Callers should set cmds_max to the largest total number (mgmt + scsi) of
>   * tasks they support. The iscsi layer reserves ISCSI_MGMT_CMDS_MAX tasks
>   * for nop handling and login/logout requests.
>   */
> @@ -3307,7 +3307,7 @@ int iscsi_conn_start(struct iscsi_cls_conn *cls_conn)
>  
>  	if (conn->ping_timeout && !conn->recv_timeout) {
>  		iscsi_conn_printk(KERN_ERR, conn, "invalid recv timeout of "
> -				  "zero. Using 5 seconds\n.");
> +				  "zero. Using 5 seconds.\n");
>  		conn->recv_timeout = 5;
>  	}
>  
> -- 
> 2.25.1
> 


      parent reply	other threads:[~2026-05-11 22:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11  9:30 [PATCH] scsi: libiscsi: fix spelling and format errors Wang Yan
2026-05-11 15:17 ` Mike Christie
2026-05-11 22:01 ` Chris Leech [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260511-resource-blaming-f423310243b5@redhat.com \
    --to=cleech@redhat.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=lduncan@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=michael.christie@oracle.com \
    --cc=open-iscsi@googlegroups.com \
    --cc=wangyan01@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox