Linux SCSI subsystem development
 help / color / mirror / Atom feed
* [PATCH] scsi: libiscsi: fix spelling and format errors
@ 2026-05-11  9:30 Wang Yan
  2026-05-11 15:17 ` Mike Christie
  2026-05-11 22:01 ` Chris Leech
  0 siblings, 2 replies; 3+ messages in thread
From: Wang Yan @ 2026-05-11  9:30 UTC (permalink / raw)
  To: lduncan, cleech, michael.christie, James.Bottomley,
	martin.petersen
  Cc: open-iscsi, linux-scsi, linux-kernel, Wang Yan

Fix two issues in libiscsi.c:
- Correct typo "numer" to "number" in iscsi_session_setup() comment
- Fix format string "seconds\n." to "seconds.\n" in recv timeout warning

Signed-off-by: Wang Yan <wangyan01@kylinos.cn>
---
 drivers/scsi/libiscsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 25857d6ed6e8..160f02f2f51d 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -3012,7 +3012,7 @@ static void iscsi_host_dec_session_cnt(struct Scsi_Host *shost)
  * This can be used by software iscsi_transports that allocate
  * a session per scsi host.
  *
- * Callers should set cmds_max to the largest total numer (mgmt + scsi) of
+ * Callers should set cmds_max to the largest total number (mgmt + scsi) of
  * tasks they support. The iscsi layer reserves ISCSI_MGMT_CMDS_MAX tasks
  * for nop handling and login/logout requests.
  */
@@ -3307,7 +3307,7 @@ int iscsi_conn_start(struct iscsi_cls_conn *cls_conn)
 
 	if (conn->ping_timeout && !conn->recv_timeout) {
 		iscsi_conn_printk(KERN_ERR, conn, "invalid recv timeout of "
-				  "zero. Using 5 seconds\n.");
+				  "zero. Using 5 seconds.\n");
 		conn->recv_timeout = 5;
 	}
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: libiscsi: fix spelling and format errors
  2026-05-11  9:30 [PATCH] scsi: libiscsi: fix spelling and format errors Wang Yan
@ 2026-05-11 15:17 ` Mike Christie
  2026-05-11 22:01 ` Chris Leech
  1 sibling, 0 replies; 3+ messages in thread
From: Mike Christie @ 2026-05-11 15:17 UTC (permalink / raw)
  To: Wang Yan, lduncan, cleech, James.Bottomley, martin.petersen
  Cc: open-iscsi, linux-scsi, linux-kernel

On 5/11/26 4:30 AM, Wang Yan wrote:
> Fix two issues in libiscsi.c:
> - Correct typo "numer" to "number" in iscsi_session_setup() comment
> - Fix format string "seconds\n." to "seconds.\n" in recv timeout warning
> 
> Signed-off-by: Wang Yan <wangyan01@kylinos.cn>

Reviewed-by: Mike Christie <michael.christie@oracle.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: libiscsi: fix spelling and format errors
  2026-05-11  9:30 [PATCH] scsi: libiscsi: fix spelling and format errors Wang Yan
  2026-05-11 15:17 ` Mike Christie
@ 2026-05-11 22:01 ` Chris Leech
  1 sibling, 0 replies; 3+ messages in thread
From: Chris Leech @ 2026-05-11 22:01 UTC (permalink / raw)
  To: Wang Yan
  Cc: lduncan, michael.christie, James.Bottomley, martin.petersen,
	open-iscsi, linux-scsi, linux-kernel

On Mon, May 11, 2026 at 05:30:30PM +0800, Wang Yan wrote:
> Fix two issues in libiscsi.c:
> - Correct typo "numer" to "number" in iscsi_session_setup() comment
> - Fix format string "seconds\n." to "seconds.\n" in recv timeout warning
> 
> Signed-off-by: Wang Yan <wangyan01@kylinos.cn>
> ---

Sure, that looks fine.

Reviewed-by: Chris Leech <cleech@redhat.com>

>  drivers/scsi/libiscsi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index 25857d6ed6e8..160f02f2f51d 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -3012,7 +3012,7 @@ static void iscsi_host_dec_session_cnt(struct Scsi_Host *shost)
>   * This can be used by software iscsi_transports that allocate
>   * a session per scsi host.
>   *
> - * Callers should set cmds_max to the largest total numer (mgmt + scsi) of
> + * Callers should set cmds_max to the largest total number (mgmt + scsi) of
>   * tasks they support. The iscsi layer reserves ISCSI_MGMT_CMDS_MAX tasks
>   * for nop handling and login/logout requests.
>   */
> @@ -3307,7 +3307,7 @@ int iscsi_conn_start(struct iscsi_cls_conn *cls_conn)
>  
>  	if (conn->ping_timeout && !conn->recv_timeout) {
>  		iscsi_conn_printk(KERN_ERR, conn, "invalid recv timeout of "
> -				  "zero. Using 5 seconds\n.");
> +				  "zero. Using 5 seconds.\n");
>  		conn->recv_timeout = 5;
>  	}
>  
> -- 
> 2.25.1
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-05-11 22:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-11  9:30 [PATCH] scsi: libiscsi: fix spelling and format errors Wang Yan
2026-05-11 15:17 ` Mike Christie
2026-05-11 22:01 ` Chris Leech

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox