From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Brian Bunker <brian@purestorage.com>,
Damien Le Moal <dlemoal@kernel.org>,
Hannes Reinecke <hare@suse.de>,
Bart Van Assche <bvanassche@acm.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Subject: [PATCH 1/2] scsi: core, target: Move three constants into <scsi/scsi_common.h>
Date: Tue, 12 May 2026 12:46:33 -0700 [thread overview]
Message-ID: <20260512194634.58145-2-bvanassche@acm.org> (raw)
In-Reply-To: <20260512194634.58145-1-bvanassche@acm.org>
Prepare for using these constants in the SCSI core.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
include/scsi/scsi_common.h | 4 ++++
include/target/target_core_base.h | 5 +----
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/include/scsi/scsi_common.h b/include/scsi/scsi_common.h
index fb58715fac86..f242040ff9d7 100644
--- a/include/scsi/scsi_common.h
+++ b/include/scsi/scsi_common.h
@@ -10,6 +10,10 @@
#include <uapi/linux/pr.h>
#include <scsi/scsi_proto.h>
+#define INQUIRY_VENDOR_LEN 8
+#define INQUIRY_MODEL_LEN 16
+#define INQUIRY_REVISION_LEN 4
+
enum scsi_pr_type {
SCSI_PR_WRITE_EXCLUSIVE = 0x01,
SCSI_PR_EXCLUSIVE_ACCESS = 0x03,
diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h
index 9a0e9f9e1ec4..002b0fc57587 100644
--- a/include/target/target_core_base.h
+++ b/include/target/target_core_base.h
@@ -8,6 +8,7 @@
#include <linux/percpu-refcount.h>
#include <linux/semaphore.h> /* struct semaphore */
#include <linux/completion.h>
+#include <scsi/scsi_common.h>
#define TARGET_CORE_VERSION "v5.0"
@@ -46,10 +47,6 @@
/* Used by transport_get_inquiry_vpd_device_ident() */
#define INQUIRY_VPD_DEVICE_IDENTIFIER_LEN 254
-#define INQUIRY_VENDOR_LEN 8
-#define INQUIRY_MODEL_LEN 16
-#define INQUIRY_REVISION_LEN 4
-
/* Attempts before moving from SHORT to LONG */
#define PYX_TRANSPORT_WINDOW_CLOSED_THRESHOLD 3
#define PYX_TRANSPORT_WINDOW_CLOSED_WAIT_SHORT 3 /* In milliseconds */
next prev parent reply other threads:[~2026-05-12 19:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 19:46 [PATCH 0/2] Rework the struct scsi_device inquiry information Bart Van Assche
2026-05-12 19:46 ` Bart Van Assche [this message]
2026-05-13 8:04 ` [PATCH 1/2] scsi: core, target: Move three constants into <scsi/scsi_common.h> Damien Le Moal
2026-05-13 9:28 ` Hannes Reinecke
2026-05-12 19:46 ` [PATCH 2/2] scsi: core: Convert inquiry information Bart Van Assche
2026-05-13 8:03 ` Damien Le Moal
2026-05-13 17:26 ` Bart Van Assche
2026-05-13 18:40 ` Guenter Roeck
2026-05-13 9:33 ` Hannes Reinecke
2026-05-13 17:40 ` Bart Van Assche
2026-05-13 12:49 ` James Bottomley
2026-05-13 17:49 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512194634.58145-2-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=brian@purestorage.com \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox