Re: [PATCH 2/2] scsi: core: Convert inquiry information

[Bart Van Assche <bvanassche@acm.org>]

On 5/13/26 5:49 AM, James Bottomley wrote:
> On Tue, 2026-05-12 at 12:46 -0700, Bart Van Assche wrote:
>> @@ -905,9 +905,9 @@ static int scsi_add_lun(struct scsi_device *sdev,
>> unsigned char *inq_result,
>>   	if (sdev->inquiry == NULL)
>>   		return SCSI_SCAN_NO_RESPONSE;
>>   
>> -	sdev->vendor = (char *) (sdev->inquiry + 8);
>> -	sdev->model = (char *) (sdev->inquiry + 16);
>> -	sdev->rev = (char *) (sdev->inquiry + 32);
>> +	strscpy(sdev->vendor, sdev->inquiry + 8);
>> +	strscpy(sdev->model, sdev->inquiry + 16);
>> +	strscpy(sdev->rev, sdev->inquiry + 32);
>>   
>>   	sdev->is_ata = strncmp(sdev->vendor, "ATA     ", 8) == 0;
>>   	if (sdev->is_ata) {
> 
> If you've gone to all the trouble to lift the lengths out as #defines,
> shouldn't we do the same with the offsets?

Hi James,

I will introduce symbolic names for the offsets in the next version of
this patch series.

Thanks,

Bart.