From: Piotr Zarycki <piotr.zarycki@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
Piotr Zarycki <piotr.zarycki@gmail.com>
Subject: [PATCH] scsi: isci: remove unused macros from scu_task_context.h
Date: Mon, 29 Jun 2026 08:22:57 +0200 [thread overview]
Message-ID: <20260629062257.986945-1-piotr.zarycki@gmail.com> (raw)
Remove three accessor macros that are defined but never used:
- scu_get_command_request_subtype()
- scu_get_command_request_full_type()
- scu_get_command_protocl_engine_group()
Also remove SCU_CONTEXT_COMMAND_REQUEST_FULLTYPE_MASK and
SCU_CONTEXT_COMMAND_PROTOCOL_ENGINE_GROUP_MASK which were only
referenced by the removed macros.
Signed-off-by: Piotr Zarycki <piotr.zarycki@gmail.com>
---
drivers/scsi/isci/scu_task_context.h | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/scsi/isci/scu_task_context.h b/drivers/scsi/isci/scu_task_context.h
index 582d22d54689..f877a5ebbbe0 100644
--- a/drivers/scsi/isci/scu_task_context.h
+++ b/drivers/scsi/isci/scu_task_context.h
@@ -193,21 +193,7 @@ typedef enum {
#define SCU_CONTEXT_COMMAND_REQUEST_SUBTYPE_SHIFT 18
#define SCU_CONTEXT_COMMAND_REQUEST_SUBTYPE_MASK 0x001C0000
-#define scu_get_command_request_subtype(x) \
- ((x) & SCU_CONTEXT_COMMAND_REQUEST_SUBTYPE_MASK)
-
-#define SCU_CONTEXT_COMMAND_REQUEST_FULLTYPE_MASK \
- (\
- SCU_CONTEXT_COMMAND_REQUEST_TYPE_MASK \
- | SCU_CONTEXT_COMMAND_REQUEST_SUBTYPE_MASK \
- )
-#define scu_get_command_request_full_type(x) \
- ((x) & SCU_CONTEXT_COMMAND_REQUEST_FULLTYPE_MASK)
-
#define SCU_CONTEXT_COMMAND_PROTOCOL_ENGINE_GROUP_SHIFT 16
-#define SCU_CONTEXT_COMMAND_PROTOCOL_ENGINE_GROUP_MASK 0x00010000
-#define scu_get_command_protocl_engine_group(x) \
- ((x) & SCU_CONTEXT_COMMAND_PROTOCOL_ENGINE_GROUP_MASK)
#define SCU_CONTEXT_COMMAND_LOGICAL_PORT_SHIFT 12
#define SCU_CONTEXT_COMMAND_LOGICAL_PORT_MASK 0x00007000
--
2.54.0
reply other threads:[~2026-06-29 6:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260629062257.986945-1-piotr.zarycki@gmail.com \
--to=piotr.zarycki@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox