[PATCH] scsi: isci: remove unused macros from scu_task

Linux SCSI subsystem development
 help / color / mirror / Atom feed

* [PATCH] scsi: isci: remove unused macros from scu_task_context.h
@ 2026-06-29  6:22 Piotr Zarycki
  2026-08-06 19:06 ` Martin K. Petersen
  0 siblings, 1 reply; 2+ messages in thread
From: Piotr Zarycki @ 2026-06-29  6:22 UTC (permalink / raw)
  To: linux-scsi; +Cc: James.Bottomley, martin.petersen, linux-kernel, Piotr Zarycki

Remove three accessor macros that are defined but never used:
- scu_get_command_request_subtype()
- scu_get_command_request_full_type()
- scu_get_command_protocl_engine_group()

Also remove SCU_CONTEXT_COMMAND_REQUEST_FULLTYPE_MASK and
SCU_CONTEXT_COMMAND_PROTOCOL_ENGINE_GROUP_MASK which were only
referenced by the removed macros.

Signed-off-by: Piotr Zarycki <piotr.zarycki@gmail.com>
---
 drivers/scsi/isci/scu_task_context.h | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/drivers/scsi/isci/scu_task_context.h b/drivers/scsi/isci/scu_task_context.h
index 582d22d54689..f877a5ebbbe0 100644
--- a/drivers/scsi/isci/scu_task_context.h
+++ b/drivers/scsi/isci/scu_task_context.h
@@ -193,21 +193,7 @@ typedef enum {
 
 #define SCU_CONTEXT_COMMAND_REQUEST_SUBTYPE_SHIFT        18
 #define SCU_CONTEXT_COMMAND_REQUEST_SUBTYPE_MASK         0x001C0000
-#define scu_get_command_request_subtype(x) \
-	((x) & SCU_CONTEXT_COMMAND_REQUEST_SUBTYPE_MASK)
-
-#define SCU_CONTEXT_COMMAND_REQUEST_FULLTYPE_MASK	 \
-	(\
-		SCU_CONTEXT_COMMAND_REQUEST_TYPE_MASK		  \
-		| SCU_CONTEXT_COMMAND_REQUEST_SUBTYPE_MASK	    \
-	)
-#define scu_get_command_request_full_type(x) \
-	((x) & SCU_CONTEXT_COMMAND_REQUEST_FULLTYPE_MASK)
-
 #define SCU_CONTEXT_COMMAND_PROTOCOL_ENGINE_GROUP_SHIFT  16
-#define SCU_CONTEXT_COMMAND_PROTOCOL_ENGINE_GROUP_MASK   0x00010000
-#define scu_get_command_protocl_engine_group(x)	\
-	((x) & SCU_CONTEXT_COMMAND_PROTOCOL_ENGINE_GROUP_MASK)
 
 #define SCU_CONTEXT_COMMAND_LOGICAL_PORT_SHIFT           12
 #define SCU_CONTEXT_COMMAND_LOGICAL_PORT_MASK            0x00007000
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] scsi: isci: remove unused macros from scu_task_context.h
  2026-06-29  6:22 [PATCH] scsi: isci: remove unused macros from scu_task_context.h Piotr Zarycki
@ 2026-08-06 19:06 ` Martin K. Petersen
  0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2026-08-06 19:06 UTC (permalink / raw)
  To: linux-scsi, Piotr Zarycki
  Cc: Martin K . Petersen, James.Bottomley, linux-kernel

On Mon, 29 Jun 2026 08:22:57 +0200, Piotr Zarycki wrote:

> Remove three accessor macros that are defined but never used:
> - scu_get_command_request_subtype()
> - scu_get_command_request_full_type()
> - scu_get_command_protocl_engine_group()
> 
> Also remove SCU_CONTEXT_COMMAND_REQUEST_FULLTYPE_MASK and
> SCU_CONTEXT_COMMAND_PROTOCOL_ENGINE_GROUP_MASK which were only
> referenced by the removed macros.
> 
> [...]

Applied to 7.3/scsi-queue, thanks!

[1/1] scsi: isci: remove unused macros from scu_task_context.h
      https://git.kernel.org/mkp/scsi/c/d756863c9bdf

-- 
Martin K. Petersen

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-08-06 19:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-29  6:22 [PATCH] scsi: isci: remove unused macros from scu_task_context.h Piotr Zarycki
2026-08-06 19:06 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox