Re: [PATCH v3 04/10] nvme-multipath: add nvme_mpath_is_{disabled, optimised}

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch relies on missing structs, headers, and Kconfig symbols, causing a fatal build failure.
--

commit b4542aff5d48fe0783ce1a5c4b163d732171214c
Author: John Garry <john.g.garry@oracle.com>

nvme-multipath: add nvme_mpath_is_{disabled, optimised}

This commit adds nvme_mpath_is_disabled and nvme_mpath_is_optimized callbacks
for multipath devices. It wires these up to the mpath_head_template structure.

> diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
> index e0573ca71ec60..6d3df1775dbeb 100644
> --- a/drivers/nvme/host/multipath.c
> +++ b/drivers/nvme/host/multipath.c
> @@ -305,6 +305,11 @@ static bool nvme_path_is_disabled(struct nvme_ns *ns)
>  	return false;
>  }
>  
> +static bool nvme_mpath_is_disabled(struct mpath_device *mpath_device)
> +{

[Severity: Low]
Does this patch depend on other missing patches in a series?

Compiling this change fails because struct mpath_device is an incomplete type.
It appears other dependencies like <linux/multipath.h> or LIBMULTIPATH are
missing from the tree.

> +	return nvme_path_is_disabled(nvme_mpath_to_ns(mpath_device));
> +}
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260703103204.3724406-1-john.g.garry@oracle.com?part=4