Re: [PATCH v3 09/10] nvme-multipath: add nvme_mpath_head_queue_if_no_path()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added wrapper nvme_mpath_head_queue_if_no_path() calls an undefined function mpath_head_queue_if_no_path(). The required header <linux/multipath.h> and the underlying libmultipath implementation are missing from the kernel tree and this patch series. Compiling the kernel with CONFIG_NVME_MULTIPATH=y will result in a build failure.
--

commit cff4d8c98386c9683c8dc00a277d4f52cdd8c6a0
Author: John Garry <john.g.garry@oracle.com>

nvme-multipath: add nvme_mpath_head_queue_if_no_path()

This commit adds a wrapper function to check if the multipath head should
queue when there are no paths. It provides both an active implementation
and a stub for when CONFIG_NVME_MULTIPATH is disabled.

> diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
> index 9fd958a426f1f..354f77dea4870 100644
> --- a/drivers/nvme/host/nvme.h
> +++ b/drivers/nvme/host/nvme.h
> @@ -1095,6 +1095,11 @@ static inline void nvme_mpath_synchronize(struct nvme_ns_head *head)
>  	mpath_synchronize(&head->mpath_head);
>  }
>  
> +static inline bool nvme_mpath_head_queue_if_no_path(struct nvme_ns_head *head)
> +{
> +	return mpath_head_queue_if_no_path(&head->mpath_head);

[Severity: Low]
Does this cause a build failure when CONFIG_NVME_MULTIPATH=y?

It appears that mpath_head_queue_if_no_path() is currently undefined. I
couldn't find a declaration or the underlying implementation for it in the
kernel tree. Compiling with this configuration might result in an undefined
reference or missing header error.

> +}
> +
>  static inline void nvme_trace_bio_complete(struct request *req)

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260703103204.3724406-1-john.g.garry@oracle.com?part=9