Re: [PATCH v2 22/33] ibmvfc: update state machine to process NVMe/FC targets

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The state machine loops were only partially updated for NVMe targets, missing the terminal deletion loop in `ibmvfc_do_work` and the rport addition loop in `ibmvfc_rport_add_thread`.
--

--- Patch [22]: [PATCH v2 22/33] ibmvfc: update state machine to process NVMe/FC targets ---
commit caac2c6b6503f6fc5585805d7ed766e74dd3cfa7
Author: Tyrel Datwyler <tyreld@linux.ibm.com>

ibmvfc: update state machine to process NVMe/FC targets

Update the host work loop and target state-machine helpers to process
NVMe targets in addition to SCSI targets.

> diff --git a/drivers/scsi/ibmvscsi/ibmvfc-core.c b/drivers/scsi/ibmvscsi/ibmvfc-core.c
> index 1185d72a8a734..ff84ca0f9f45a 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc-core.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc-core.c
[ ... ]
> @@ -5988,6 +6018,12 @@ static void ibmvfc_do_work(struct ibmvfc_host *vhost)
>  				break;
>  			}
>  		}
> +		list_for_each_entry(tgt, &vhost->nvme_scrqs.targets, queue) {
> +			if (tgt->action == IBMVFC_TGT_ACTION_LOGOUT_RPORT) {
> +				tgt->job_step(tgt);
> +				break;
> +			}
> +		}
>  
>  		if (ibmvfc_dev_logo_to_do(vhost)) {
>  			spin_unlock_irqrestore(vhost->host->host_lock, flags);

[Severity: High]
Does this code introduce a regression by missing the equivalent terminal
deletion loop for NVMe targets?

While this block handles IBMVFC_TGT_ACTION_LOGOUT_RPORT for nvme_scrqs.targets,
shortly after this in ibmvfc_do_work() there is a loop for SCSI terminal
deletion (handling IBMVFC_TGT_ACTION_DEL_RPORT and
IBMVFC_TGT_ACTION_DEL_AND_LOGOUT_RPORT) that doesn't appear to be updated to
include vhost->nvme_scrqs.targets.

If that loop is omitted, won't NVMe targets marked for deletion remain in the
list indefinitely, failing to cancel their timers and leaking the target memory?

Additionally, looking at ibmvfc_rport_add_thread(), it only iterates over
vhost->scsi_scrqs.targets. Should NVMe targets that have tgt->add_rport = 1
also be processed there? If they are ignored by the worker thread, it appears
they will never be passed to ibmvfc_nvme_register_remoteport(), preventing the
NVMe targets from registering with the transport.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260723000149.969416-1-tyreld@linux.ibm.com?part=22