Re: [PATCH v4 01/28] libmultipath: Add initial framework

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The workqueue `mpath_wq` is allocated in `mpath_init()` but never used in the module.
--

--- Patch [1]: [PATCH v4 01/28] libmultipath: Add initial framework ---
commit 170d80e77c0bd0720941ff23ec89cb2a3960288f
Author: John Garry <john.g.garry@oracle.com>

libmultipath: Add initial framework

This commit adds an initial framework for libmultipath, a library for
multipath-capable block drivers. It includes basic support to add and remove
the head structure, mpath_head, and introduces the mpath_device structure.

> diff --git a/lib/multipath.c b/lib/multipath.c
> new file mode 100644
> index 0000000000000..9cc398d266adf
> --- /dev/null
> +++ b/lib/multipath.c

[ ... ]

> +static int __init mpath_init(void)
> +{
> +	mpath_wq = alloc_workqueue("mpath-wq",
> +			WQ_UNBOUND | WQ_MEM_RECLAIM | WQ_SYSFS, 0);

[Severity: Low]
Is this workqueue meant to be used in this patch?

The workqueue mpath_wq is allocated in mpath_init() and destroyed in
mpath_exit(), but no work is ever queued to it. Does this allocate an unused
resource, or is it intended to be used by subsequent patches?

> +	if (!mpath_wq)
> +		return -ENOMEM;
> +	return 0;
> +}
> +
> +static void __exit mpath_exit(void)
> +{
> +	destroy_workqueue(mpath_wq);
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260723093627.2327456-1-john.g.garry@oracle.com?part=1