Re: [PATCH v4 24/28] scsi: sd: add multipath disk attr groups

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch defines the `sd_mpath_disk_attr_groups` sysfs attribute group and its associated callback functions but never assigns it to any device or class (e.g., `sd_mpath_disk_class`). This leaves the multipath sysfs attributes entirely unexposed and the new code dead.
--

--- Patch [24]: [PATCH v4 24/28] scsi: sd: add multipath disk attr groups ---
commit d9075e7051637dd60fcce05f493768de652548d9
Author: John Garry <john.garry@linux.dev>

scsi: sd: add multipath disk attr groups

This commit adds sysfs attribute groups for multipath disks, including
delayed disk removal and the existing mpath attribute group.

> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index 242a15bc2c5bb..36c745cbb2619 100644
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
[ ... ]
> +static const struct attribute_group sd_mpath_disk_attr_group = {
> +	.attrs		= sd_mpath_disk_attrs,
> +};
> +
> +__maybe_unused
> +static const struct attribute_group *sd_mpath_disk_attr_groups[] = {
> +	&sd_mpath_disk_attr_group,
> +	&mpath_attr_group,
> +	NULL
> +};

[Severity: Medium]
Are these attribute groups actually registered anywhere? It looks like
sd_mpath_disk_attr_groups is defined and marked __maybe_unused, but never
assigned to a device or class to expose the sysfs attributes to userspace,
leaving this code essentially unreachable.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260723093627.2327456-1-john.g.garry@oracle.com?part=24