Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>,
	"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
	linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
	Niklas Cassel <cassel@kernel.org>,
	linux-usb@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>
Subject: [PATCH v3 25/40] scsi: ps3rom: use 16-bits defined sense codes
Date: Fri,  4 Sep 2026 09:26:29 +0900	[thread overview]
Message-ID: <20260904002644.157668-26-dlemoal@kernel.org> (raw)
In-Reply-To: <20260904002644.157668-1-dlemoal@kernel.org>

Refactor the PS3 DVD driver to use scsi_set_sense() and replace all
hard-coded additional sense codes and additional sense code qualifiers
with the enum values defined in include/scsi/scsi_sense.h. This helps with
code clarity as the sense codes being processed are easier to test and
self-documented.

No functional change intended.

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
---
 drivers/scsi/ps3rom.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/ps3rom.c b/drivers/scsi/ps3rom.c
index a9c727d22931..c63c581b493c 100644
--- a/drivers/scsi/ps3rom.c
+++ b/drivers/scsi/ps3rom.c
@@ -233,7 +233,8 @@ static enum scsi_qc_status ps3rom_queuecommand_lck(struct scsi_cmnd *cmd)
 	}
 
 	if (res) {
-		scsi_build_sense(cmd, 0, ILLEGAL_REQUEST, 0, 0);
+		scsi_set_sense(cmd, 0, ILLEGAL_REQUEST,
+			       NO_ADDITIONAL_SENSE_INFORMATION);
 		cmd->result = res;
 		priv->curr_cmd = NULL;
 		scsi_done(cmd);
@@ -316,7 +317,7 @@ static irqreturn_t ps3rom_interrupt(int irq, void *data)
 		goto done;
 	}
 
-	scsi_build_sense(cmd, 0, sense_key, asc, ascq);
+	scsi_set_sense(cmd, 0, sense_key, scsi_sense_code(asc, ascq));
 
 done:
 	priv->curr_cmd = NULL;
-- 
2.55.0


  parent reply	other threads:[~2026-09-04  0:27 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04  0:26 [PATCH v3 00/40] Use defined 16-bits ASC/ASCQ combinations Damien Le Moal
2026-09-04  0:26 ` [PATCH v3 01/40] scsi: define all additional sense codes and their qualifiers Damien Le Moal
2026-09-04  0:38   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 02/40] scsi: constants: use defined sense codes Damien Le Moal
2026-09-04  0:36   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 03/40] scsi: constants: rename internal struct field names Damien Le Moal
2026-09-04  0:38   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 04/40] scsi: rename sense field of struct scsi_failure Damien Le Moal
2026-09-04  0:43   ` sashiko-bot
2026-09-04 10:08   ` Johannes Thumshirn
2026-09-04  0:26 ` [PATCH v3 05/40] scsi: prepare for using 16-bits defined sense codes Damien Le Moal
2026-09-04  0:45   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 06/40] scsi: use struct scsi_sense_hdr to log sense keys and codes Damien Le Moal
2026-09-04  0:48   ` sashiko-bot
2026-09-04 10:11   ` Johannes Thumshirn
2026-09-04  0:26 ` [PATCH v3 07/40] scsi: core: use 16-bits defined sense codes Damien Le Moal
2026-09-04  0:53   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 08/40] scsi: sd: " Damien Le Moal
2026-09-04  1:04   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 09/40] scsi: sr: " Damien Le Moal
2026-09-04  1:02   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 10/40] scsi: ses: " Damien Le Moal
2026-09-04  1:06   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 11/40] scsi: ch: " Damien Le Moal
2026-09-04  1:09   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 12/40] scsi: st: " Damien Le Moal
2026-09-04  1:11   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 13/40] scsi: device_handlers: hp_sw: " Damien Le Moal
2026-09-04  1:13   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 14/40] scsi: device_handlers: rdac: " Damien Le Moal
2026-09-04  1:15   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 15/40] scsi: device_handlers: emc: " Damien Le Moal
2026-09-04  1:20   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 16/40] scsi: device_handlers: alua: " Damien Le Moal
2026-09-04  1:27   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 17/40] scsi: mpt3sas: " Damien Le Moal
2026-09-04  1:26   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 18/40] scsi: mpi3mr: " Damien Le Moal
2026-09-04  1:32   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 19/40] scsi: 3w-xxxx: " Damien Le Moal
2026-09-04  1:33   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 20/40] scsi: leapraid: " Damien Le Moal
2026-09-04  1:39   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 21/40] scsi: megaraid: " Damien Le Moal
2026-09-04  1:42   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 22/40] scsi: myrX: " Damien Le Moal
2026-09-04  1:53   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 23/40] scsi: smartpqi: " Damien Le Moal
2026-09-04  1:48   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 24/40] scsi: qla2xxx: " Damien Le Moal
2026-09-04  1:52   ` sashiko-bot
2026-09-04  0:26 ` Damien Le Moal [this message]
2026-09-04  2:00   ` [PATCH v3 25/40] scsi: ps3rom: " sashiko-bot
2026-09-04  0:26 ` [PATCH v3 26/40] scsi: lpfc: " Damien Le Moal
2026-09-04  2:00   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 27/40] scsi: stex: " Damien Le Moal
2026-09-04  2:08   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 28/40] scsi: mvumi: " Damien Le Moal
2026-09-04  2:12   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 29/40] scsi: libiscsi: " Damien Le Moal
2026-09-04  2:12   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 30/40] scsi: ibmvscsi_tgt: " Damien Le Moal
2026-09-04  2:20   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 31/40] scsi: scsi_debug: " Damien Le Moal
2026-09-04  2:23   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 32/40] scsi: hpsa: " Damien Le Moal
2026-09-04  2:27   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 33/40] scsi: storvsc: " Damien Le Moal
2026-09-04  2:41   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 34/40] target: " Damien Le Moal
2026-09-04  2:37   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 35/40] usb: storage: " Damien Le Moal
2026-09-04  2:43   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 36/40] cdrom: " Damien Le Moal
2026-09-04  2:46   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 37/40] ata: libata: " Damien Le Moal
2026-09-04  2:49   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 38/40] s390: scsi: " Damien Le Moal
2026-09-04  2:50   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 39/40] scsi: cleanup scsi_proto.h Damien Le Moal
2026-09-04  2:56   ` sashiko-bot
2026-09-04  0:26 ` [PATCH v3 40/40] scsi: remove scsi_build_sense() and scsi_build_sense_buffer() Damien Le Moal
2026-09-04  2:53   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260904002644.157668-26-dlemoal@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=cassel@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hca@linux.ibm.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox