Re: [PATCH v3 08/40] scsi: sd: use 16-bits defined sense codes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Refactoring changes `sd_zbc_complete()` to strict ASC/ASCQ match instead of just ASC, unintentionally altering behavior.
--

commit 5c4223357b4b8d6bbeafe176fdc1d3eeb2183125
Author: Damien Le Moal <dlemoal@kernel.org>
Subject: scsi: sd: use 16-bits defined sense codes

This commit refactors the SCSI disk driver to use 16-bit sense codes where
possible, replacing hard-coded asc and ascq values with enums from
include/scsi/scsi_sense.h to improve code clarity.

> diff --git a/drivers/scsi/sd_zbc.c b/drivers/scsi/sd_zbc.c
> --- a/drivers/scsi/sd_zbc.c
> +++ b/drivers/scsi/sd_zbc.c
> @@ -369,7 +369,7 @@ unsigned int sd_zbc_complete(struct scsi_cmnd *cmd, unsigned int good_bytes,
>  	if (op_is_zone_mgmt(req_op(rq)) &&
>  	    result &&
>  	    sshdr->sense_key == ILLEGAL_REQUEST &&
> -	    sshdr->asc == 0x24) {
> +	    sshdr->sense_code == INVALID_FIELD_IN_CDB) {

[Severity: Medium]
Could this refactoring introduce a regression in error handling for
non-compliant or buggy devices?

The previous code checked only sshdr->asc == 0x24 (allowing any ascq),
whereas checking the 16-bit sshdr->sense_code against INVALID_FIELD_IN_CDB
requires an exact match where ascq is 0x00.

If a device returns an asc of 0x24 with a non-zero ascq for a zone
management command attempted on a conventional zone, the kernel will no
longer quiet the expected error with RQF_QUIET, potentially leading to
error log spam.

Since the commit message notes "No functional change intended", and other
parts of the patch (like in sd_done() in sd.c) deliberately preserve the
"any ascq" behavior by using scsi_sense_asc(sshdr) == ASC_INVALID_FIELD_IN_CDB,
should this code use scsi_sense_asc() here as well?

>  		/*
>  		 * INVALID FIELD IN CDB error: a zone management command was
>  		 * attempted on a conventional zone. Nothing to worry about,

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904002644.157668-1-dlemoal@kernel.org?part=8