Re: [PATCH 5/6] generic: test I/O on devices with T10 protection information

[Christoph Hellwig <hch@lst.de>]

On Tue, Sep 01, 2026 at 12:08:59PM +0530, Kanchan Joshi wrote:
> On 8/31/2026 12:15 PM, Christoph Hellwig wrote:
> > +test_dif()
> > +{
> > +	local pi_type=$1
> > +	local pi_enable="$2"
> > +
> > +	scsi_debug_pi_opts="write_same_length=0 dif=${pi_type} dix=1"
> > +	SCSI_DEBUG_DEV=`_get_scsi_debug_dev 512 512 0 $size $scsi_debug_pi_opts`
> > +
> > +	SCSI_DEBUG_MNT="$TEST_DIR/scsi_debug_$seq"
> > +	rm -rf $SCSI_DEBUG_MNT
> > +	mkdir $SCSI_DEBUG_MNT
> > +
> > +	_mkfs_dev $SCSI_DEBUG_DEV || \
> > +		_fail "Can't make $FSTYP on DIF-enabled scsi_debug device"
> > +	run_check _mount $SCSI_DEBUG_DEV $SCSI_DEBUG_MNT
> > +	bsize=$($here/src/min_dio_alignment $SCSI_DEBUG_MNT $SCSI_DEBUG_DEV)
> 
> bsize remains unused.

_run_fsx uses it through the (somewhat odd) BSIZE substitution.

> dio_opts is unused.

Yeah.

> 
> > +	fsx_run -N 10000            -l 500000 -r BSIZE -w BSIZE -Z -R -W
> 
> Is passing BSIZE correct?

See above :)