From: Christoph Hellwig <hch@lst.de>
To: Anuj Gupta/Anuj Gupta <anuj20.g@samsung.com>
Cc: Christoph Hellwig <hch@lst.de>, Zorro Lang <zlang@kernel.org>,
fstests@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Kanchan Joshi <joshi.k@samsung.com>,
John Garry <john.g.garry@oracle.com>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 6/6] generic: test corruption detection using T10 protection information
Date: Mon, 7 Sep 2026 07:49:26 +0200 [thread overview]
Message-ID: <20260907054926.GC31481@lst.de> (raw)
In-Reply-To: <93041ae8-da31-4482-b12c-04750629f475@samsung.com>
On Thu, Sep 03, 2026 at 11:30:26AM +0530, Anuj Gupta/Anuj Gupta wrote:
> > + if [ "$last" -eq 1 ]; then
> > + echo "adding to $phys_blk" >> $seqres.full
> > + phys_blk=$((phys_blk + 127))
>
> last sector for a 4096-byte block size would be 1023 not 127 right?
> maybe use something like this to calculate the last sector?
>
> phys_blk=$((phys_blk + (128 * blksz / 512) - 1))
>
> and maybe rename it to phys_sector
Yeah. Currently we force 512 byte blocks when setting up the
scsi_debug device, but it doesn't hurt to be consistent in the
arithmetics.
next prev parent reply other threads:[~2026-09-07 5:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 6:45 add tests for file system on devices using protection information v3 Christoph Hellwig
2026-08-31 6:45 ` [PATCH 1/6] common/scsi_debug: don't slow down I/O Christoph Hellwig
2026-08-31 6:45 ` [PATCH 2/6] common: factor out a _bdev_disk_name helper Christoph Hellwig
2026-08-31 17:03 ` Darrick J. Wong
2026-08-31 6:45 ` [PATCH 3/6] common: add a _sysfs_block_integrity_path helper Christoph Hellwig
2026-08-31 17:03 ` Darrick J. Wong
2026-08-31 6:45 ` [PATCH 4/6] add a "pi" group Christoph Hellwig
2026-08-31 6:45 ` [PATCH 5/6] generic: test I/O on devices with T10 protection information Christoph Hellwig
2026-09-01 6:38 ` Kanchan Joshi
2026-09-07 5:48 ` Christoph Hellwig
2026-09-03 6:01 ` Anuj Gupta/Anuj Gupta
2026-08-31 6:45 ` [PATCH 6/6] generic: test corruption detection using " Christoph Hellwig
2026-09-03 6:00 ` Anuj Gupta/Anuj Gupta
2026-09-07 5:49 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-09-07 7:58 add tests for file system on devices using protection information v4 Christoph Hellwig
2026-09-07 7:58 ` [PATCH 6/6] generic: test corruption detection using T10 protection information Christoph Hellwig
2026-09-08 14:36 ` Kanchan Joshi
2026-09-11 7:08 add tests for file system on devices using protection information v5 Christoph Hellwig
2026-09-11 7:08 ` [PATCH 6/6] generic: test corruption detection using T10 protection information Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907054926.GC31481@lst.de \
--to=hch@lst.de \
--cc=anuj20.g@samsung.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=john.g.garry@oracle.com \
--cc=joshi.k@samsung.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox