From: Karl Mehltretter <kmehltretter@gmail.com>
To: Hannes Reinecke <hare@suse.de>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <mkp@kernel.org>
Cc: Karl Mehltretter <kmehltretter@gmail.com>,
Chris Leech <cleech@redhat.com>,
Robert Love <robert.w.love@intel.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] scsi: fcoe: Fix the return value in fcoe_interface_create() kernel-doc
Date: Sat, 12 Sep 2026 08:28:03 +0200 [thread overview]
Message-ID: <20260912062803.42969-1-kmehltretter@gmail.com> (raw)
fcoe_interface_create() returns an ERR_PTR() on failure, but its
kernel-doc still promises NULL on error. Its error paths switched to
error pointers when FCoE module references were added for vports.
Update the return documentation to match the implementation.
Fixes: 7287fb911409 ("[SCSI] fcoe: Fix module reference count for vports")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
drivers/scsi/fcoe/fcoe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index 438ac7c3a9e3fd548a42779c4d753320ec79a854..2c86d8a06e410c99e02f5c7f2ab96a908dda199a 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -375,7 +375,7 @@ static int fcoe_interface_setup(struct fcoe_interface *fcoe,
* @netdev: The net device to create the FCoE interface on
* @fip_mode: The mode to use for FIP
*
- * Returns: pointer to a struct fcoe_interface or NULL on error
+ * Returns: pointer to a struct fcoe_interface or an ERR_PTR() on error
*/
static struct fcoe_interface *fcoe_interface_create(struct net_device *netdev,
enum fip_mode fip_mode)
--
2.39.5 (Apple Git-154)
reply other threads:[~2026-09-12 6:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260912062803.42969-1-kmehltretter@gmail.com \
--to=kmehltretter@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=cleech@redhat.com \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkp@kernel.org \
--cc=robert.w.love@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox