* [PATCH] scsi: fcoe: Fix the return value in fcoe_interface_create() kernel-doc
@ 2026-09-12 6:28 Karl Mehltretter
0 siblings, 0 replies; only message in thread
From: Karl Mehltretter @ 2026-09-12 6:28 UTC (permalink / raw)
To: Hannes Reinecke, James E.J. Bottomley, Martin K. Petersen
Cc: Karl Mehltretter, Chris Leech, Robert Love, linux-scsi,
linux-kernel
fcoe_interface_create() returns an ERR_PTR() on failure, but its
kernel-doc still promises NULL on error. Its error paths switched to
error pointers when FCoE module references were added for vports.
Update the return documentation to match the implementation.
Fixes: 7287fb911409 ("[SCSI] fcoe: Fix module reference count for vports")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
drivers/scsi/fcoe/fcoe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index 438ac7c3a9e3fd548a42779c4d753320ec79a854..2c86d8a06e410c99e02f5c7f2ab96a908dda199a 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -375,7 +375,7 @@ static int fcoe_interface_setup(struct fcoe_interface *fcoe,
* @netdev: The net device to create the FCoE interface on
* @fip_mode: The mode to use for FIP
*
- * Returns: pointer to a struct fcoe_interface or NULL on error
+ * Returns: pointer to a struct fcoe_interface or an ERR_PTR() on error
*/
static struct fcoe_interface *fcoe_interface_create(struct net_device *netdev,
enum fip_mode fip_mode)
--
2.39.5 (Apple Git-154)
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-09-12 6:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-12 6:28 [PATCH] scsi: fcoe: Fix the return value in fcoe_interface_create() kernel-doc Karl Mehltretter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox