Re: [PATCH RFC v6 1/1] leds: asus-aura-scsi: Add ASUS Aura RGB LED driver for ROG NVMe enclosures

[Lee Jones <lee@kernel.org>]

On Wed, 16 Sep 2026, sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] leds: build failure due to undefined kzalloc_obj()

Please review, explain or fix the Sashiko review(s).

If this is a set, this request includes the other patches too.

> --
> 
> commit 8323106d834da191a6608c0c1f5330cc2b52094f
> Author: Liang Haowen <nbg2974@gmail.com>
> 
> leds: asus-aura-scsi: Add ASUS Aura RGB LED driver for ROG NVMe enclosures
> 
> This commit adds a new driver for ASUS Aura RGB LEDs on ROG external NVMe
> enclosures. It exposes the 4 independently addressable LEDs as multicolor LED
> class devices driven via vendor SCSI commands.
> 
> > diff --git a/drivers/leds/leds-asus-aura-scsi.c b/drivers/leds/leds-asus-aura-scsi.c
> > new file mode 100644
> > index 0000000000000..4e039bdbe76ac
> > --- /dev/null
> > +++ b/drivers/leds/leds-asus-aura-scsi.c
> [ ... ]
> > +static int asus_aura_attach(struct scsi_device *sdev)
> > +{
> > +	struct asus_aura_zone *zone;
> > +	int i, ret;
> > +
> > +	if (strncmp(sdev->vendor, ARION_INQ_VENDOR, strlen(ARION_INQ_VENDOR)) ||
> > +	    strncmp(sdev->model, ARION_INQ_MODEL, strlen(ARION_INQ_MODEL)))
> > +		return SCSI_DH_DEV_UNSUPP;
> > +
> > +	zone = kzalloc_obj(*zone, GFP_KERNEL);
> 
> [Severity: Low]
> Does this code fail to compile because kzalloc_obj() is undefined? In
> asus_aura_attach() in drivers/leds/leds-asus-aura-scsi.c, this line triggers a
> compilation error since kzalloc_obj() is not a valid Linux kernel memory
> allocation API. Should this be a call to kzalloc(sizeof(*zone), GFP_KERNEL)
> instead?
> 
> > +	if (!zone)
> > +		return SCSI_DH_NOMEM;
> > +	zone->sdev = sdev;
> > +	spin_lock_init(&zone->lock);
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/202609162200.RFCv6-1.lhw@gmail.com?part=1

-- 
Lee Jones