From: Steven Rostedt <rostedt@kernel.org>
To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Cc: "Masami Hiramatsu" <mhiramat@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Vineeth Pillai" <vineeth@bitbyteword.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Aaron Conole" <aconole@redhat.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Anna-Maria Behnsen" <anna-maria@linutronix.de>,
"Borislav Petkov" <bp@alien8.de>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Christian König" <christian.koenig@amd.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Danilo Krummrich" <dakr@kernel.org>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"David Airlie" <airlied@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eelco Chaudron" <echaudro@redhat.com>,
"Eric Dumazet" <edumazet@kernel.org>,
"Frederic Weisbecker" <frederic@kernel.org>,
"Ilya Maximets" <i.maximets@ovn.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Jiri Pirko" <jiri@resnulli.us>,
"John Fastabend" <john.fastabend@gmail.com>,
"Jon Maloy" <jmaloy@redhat.com>,
"Koby Elbaz" <koby.elbaz@intel.com>,
"Konstantin Sinyuk" <konstantin.sinyuk@intel.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Marcelo Ricardo Leitner" <marcelo.leitner@gmail.com>,
"Martin K. Petersen" <mkp@kernel.org>,
"Matthew Brost" <matthew.brost@intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"MyungJoo Ham" <myungjoo.ham@samsung.com>,
"Oded Gabbay" <ogabbay@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Philipp Stanner" <phasta@kernel.org>,
"Simona Vetter" <simona@ffwll.ch>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Thomas Gleixner" <tglx@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
tipc-discussion@lists.sourceforge.net,
"Tung Quang Nguyen" <tung.quang.nguyen@est.tech>,
"Xin Long" <lucien.xin@gmail.com>,
x86@kernel.org, amd-gfx@lists.freedesktop.org,
bpf@vger.kernel.org, dev@openvswitch.org,
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
linux-pm@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-sctp@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH 2/9] accel/habanalabs: Use trace_call__##name() at guarded tracepoint call sites
Date: Tue, 27 Oct 2026 11:37:00 -0400 [thread overview]
Message-ID: <20261027154412.834382801@kernel.org> (raw)
In-Reply-To: 20261027153658.703730257@kernel.org
From: Vineeth Pillai <vineeth@bitbyteword.org>
Replace trace_foo() with the new trace_call__foo() at sites already
guarded by trace_foo_enabled(), avoiding a redundant
static_branch_unlikely() re-evaluation inside the tracepoint.
trace_call__foo() calls the tracepoint callbacks directly without
utilizing the static branch again.
Original v2 series:
https://lore.kernel.org/linux-trace-kernel/20260323160052.17528-1-vineeth@bitbyteword.org/
Parts of the original v2 series have already been merged in mainline.
This patch is being reposted as a follow-up cleanup for the remaining
unmerged pieces.
Link: https://patch.msgid.link/20260515135914.2238789-1-vineeth@bitbyteword.org
Suggested-by: Steven Rostedt <rostedt@goodmis.org>
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Vineeth Pillai (Google) <vineeth@bitbyteword.org>
Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
drivers/accel/habanalabs/common/device.c | 9 +++++----
drivers/accel/habanalabs/common/mmu/mmu.c | 3 ++-
drivers/accel/habanalabs/common/pci/pci.c | 6 ++++--
3 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/accel/habanalabs/common/device.c b/drivers/accel/habanalabs/common/device.c
index 09b27bac3a31..68c6f973d53f 100644
--- a/drivers/accel/habanalabs/common/device.c
+++ b/drivers/accel/habanalabs/common/device.c
@@ -132,8 +132,9 @@ static void *hl_dma_alloc_common(struct hl_device *hdev, size_t size, dma_addr_t
}
if (trace_habanalabs_dma_alloc_enabled() && !ZERO_OR_NULL_PTR(ptr))
- trace_habanalabs_dma_alloc(&(hdev)->pdev->dev, (u64) (uintptr_t) ptr, *dma_handle,
- size, caller);
+ trace_call__habanalabs_dma_alloc(&(hdev)->pdev->dev,
+ (u64) (uintptr_t) ptr,
+ *dma_handle, size, caller);
return ptr;
}
@@ -2656,7 +2657,7 @@ inline u32 hl_rreg(struct hl_device *hdev, u32 reg)
u32 val = readl(hdev->rmmio + reg);
if (unlikely(trace_habanalabs_rreg32_enabled()))
- trace_habanalabs_rreg32(&(hdev)->pdev->dev, reg, val);
+ trace_call__habanalabs_rreg32(&(hdev)->pdev->dev, reg, val);
return val;
}
@@ -2674,7 +2675,7 @@ inline u32 hl_rreg(struct hl_device *hdev, u32 reg)
inline void hl_wreg(struct hl_device *hdev, u32 reg, u32 val)
{
if (unlikely(trace_habanalabs_wreg32_enabled()))
- trace_habanalabs_wreg32(&(hdev)->pdev->dev, reg, val);
+ trace_call__habanalabs_wreg32(&(hdev)->pdev->dev, reg, val);
writel(val, hdev->rmmio + reg);
}
diff --git a/drivers/accel/habanalabs/common/mmu/mmu.c b/drivers/accel/habanalabs/common/mmu/mmu.c
index 6c7c4ff8a8a9..dd8b6fb3aa1f 100644
--- a/drivers/accel/habanalabs/common/mmu/mmu.c
+++ b/drivers/accel/habanalabs/common/mmu/mmu.c
@@ -263,7 +263,8 @@ int hl_mmu_unmap_page(struct hl_ctx *ctx, u64 virt_addr, u32 page_size, bool flu
mmu_funcs->flush(ctx);
if (trace_habanalabs_mmu_unmap_enabled() && !rc)
- trace_habanalabs_mmu_unmap(&hdev->pdev->dev, virt_addr, 0, page_size, flush_pte);
+ trace_call__habanalabs_mmu_unmap(&hdev->pdev->dev, virt_addr, 0,
+ page_size, flush_pte);
return rc;
}
diff --git a/drivers/accel/habanalabs/common/pci/pci.c b/drivers/accel/habanalabs/common/pci/pci.c
index 81cbd8697d4c..12663e8e12e0 100644
--- a/drivers/accel/habanalabs/common/pci/pci.c
+++ b/drivers/accel/habanalabs/common/pci/pci.c
@@ -123,7 +123,8 @@ int hl_pci_elbi_read(struct hl_device *hdev, u64 addr, u32 *data)
pci_read_config_dword(pdev, mmPCI_CONFIG_ELBI_DATA, data);
if (unlikely(trace_habanalabs_elbi_read_enabled()))
- trace_habanalabs_elbi_read(&hdev->pdev->dev, (u32) addr, val);
+ trace_call__habanalabs_elbi_read(&hdev->pdev->dev,
+ (u32) addr, val);
return 0;
}
@@ -186,7 +187,8 @@ static int hl_pci_elbi_write(struct hl_device *hdev, u64 addr, u32 data)
if ((val & PCI_CONFIG_ELBI_STS_MASK) == PCI_CONFIG_ELBI_STS_DONE) {
if (unlikely(trace_habanalabs_elbi_write_enabled()))
- trace_habanalabs_elbi_write(&hdev->pdev->dev, (u32) addr, val);
+ trace_call__habanalabs_elbi_write(&hdev->pdev->dev,
+ (u32) addr, val);
return 0;
}
--
2.53.0
next prev parent reply other threads:[~2026-10-27 15:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 15:36 [PATCH 0/9] tracing: Use trace_call__FOO() for tracepoints behind trace_FOO_enabled() Steven Rostedt
2026-10-27 15:36 ` [PATCH 1/9] net: Use trace_call__##name() at guarded tracepoint call sites Steven Rostedt
2026-10-27 15:37 ` Steven Rostedt [this message]
2026-10-27 15:37 ` [PATCH 3/9] devfreq: " Steven Rostedt
2026-10-27 15:37 ` [PATCH 4/9] dma-buf: " Steven Rostedt
2026-10-27 15:37 ` [PATCH 5/9] drm: " Steven Rostedt
2026-10-27 15:37 ` [PATCH 6/9] scsi: ufs: " Steven Rostedt
2026-10-27 15:37 ` [PATCH 7/9] net: devlink: " Steven Rostedt
2026-10-27 15:37 ` [PATCH 8/9] kernel: time, trace: " Steven Rostedt
2026-10-27 15:37 ` [PATCH 9/9] x86: msr: " Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261027154412.834382801@kernel.org \
--to=rostedt@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=aconole@redhat.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=anna-maria@linutronix.de \
--cc=ast@kernel.org \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=christian.koenig@amd.com \
--cc=cw00.choi@samsung.com \
--cc=dakr@kernel.org \
--cc=daniel@iogearbox.net \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=echaudro@redhat.com \
--cc=edumazet@kernel.org \
--cc=frederic@kernel.org \
--cc=hawk@kernel.org \
--cc=i.maximets@ovn.org \
--cc=jiri@resnulli.us \
--cc=jmaloy@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=koby.elbaz@intel.com \
--cc=konstantin.sinyuk@intel.com \
--cc=kuba@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marcelo.leitner@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=matthew.brost@intel.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=mkp@kernel.org \
--cc=mripard@kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=phasta@kernel.org \
--cc=simona@ffwll.ch \
--cc=sumit.semwal@linaro.org \
--cc=tglx@kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=tung.quang.nguyen@est.tech \
--cc=tzimmermann@suse.de \
--cc=vineeth@bitbyteword.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox