Re: [PATCH] scsi: ufs: core: Fix link error when CONFIG_RPMB=m

[Bean Huo <beanhuo@iokpp.de>]

On Mon, 2025-12-01 at 12:25 -0500, Martin K. Petersen wrote:
> 
> Hi Bean!
> 
> > When CONFIG_SCSI_UFSHCD=y and CONFIG_RPMB=m, the kernel fails to link
> > with undefined references to ufs_rpmb_probe() and ufs_rpmb_remove():
> > 
> >   ld: drivers/ufs/core/ufshcd.c:8950: undefined reference to
> > `ufs_rpmb_probe'
> >   ld: drivers/ufs/core/ufshcd.c:10505: undefined reference to
> > `ufs_rpmb_remove'
> > 
> > The issue occurs because IS_ENABLED(CONFIG_RPMB) evaluates to true
> > when CONFIG_RPMB=m, causing the header to declare the real function
> > prototypes.
> 
> This now breaks the modular build for me.
> 

Hi Martin,

I tested both IS_BUILTIN and IS_REACHABLE for the RPMB dependencies both work
correctly in my configuration.

IS_REACHABLE would provide more flexibility for module configurations, but in
practice, I don't have experience with UFS being used as a module.

Would you prefer IS_REACHABLE for theoretical flexibility, or is IS_BUILTIN
acceptable given the typical UFS built-in configuration?

Kind regards,
Bean