From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Damien Le Moal <dlemoal@kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] scsi: sd: Introduce manage_shutdown device flag
Date: Wed, 25 Oct 2023 07:57:51 -0400 [thread overview]
Message-ID: <39fef5f8e090d50eb22d73d6bb39b21edf62b565.camel@HansenPartnership.com> (raw)
In-Reply-To: <20231025070117.464903-1-dlemoal@kernel.org>
On Wed, 2023-10-25 at 16:01 +0900, Damien Le Moal wrote:
> +++ b/include/scsi/scsi_device.h
> @@ -164,6 +164,7 @@ struct scsi_device {
>
> bool manage_system_start_stop; /* Let HLD (sd) manage system
> start/stop */
> bool manage_runtime_start_stop; /* Let HLD (sd) manage
> runtime start/stop */
> + bool manage_shutdown; /* Let HLD (sd) manage shutdown */
>
I think at least 85% of the world gets confused about the difference
between runtime/system start/stop and shutdown. Could we at least
point to a doc explaining it in a comment here?
James
next prev parent reply other threads:[~2023-10-25 11:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 7:01 [PATCH] scsi: sd: Introduce manage_shutdown device flag Damien Le Moal
2023-10-25 7:14 ` Damien Le Moal
2023-10-25 11:57 ` James Bottomley [this message]
2023-10-25 21:30 ` Damien Le Moal
2023-10-26 12:01 ` James Bottomley
2023-10-26 21:36 ` Bart Van Assche
2023-10-27 0:26 ` Damien Le Moal
2023-10-27 0:37 ` James Bottomley
2023-10-27 0:57 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39fef5f8e090d50eb22d73d6bb39b21edf62b565.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox