Re: [PATCH] scsi: sd: Introduce manage_shutdown device flag

[Damien Le Moal <dlemoal@kernel.org>]

On 10/25/23 20:57, James Bottomley wrote:
> On Wed, 2023-10-25 at 16:01 +0900, Damien Le Moal wrote:
>> +++ b/include/scsi/scsi_device.h
>> @@ -164,6 +164,7 @@ struct scsi_device {
>>  
>>         bool manage_system_start_stop; /* Let HLD (sd) manage system
>> start/stop */
>>         bool manage_runtime_start_stop; /* Let HLD (sd) manage
>> runtime start/stop */
>> +       bool manage_shutdown;   /* Let HLD (sd) manage shutdown */
>>  
> 
> I think at least 85% of the world gets confused about the difference
> between runtime/system start/stop and shutdown.  Could we at least
> point to a doc explaining it in a comment here?

Would improving the comments here be enough ? E.g. something like:

	/* Let the HLD (sd) manage system suspend (start) and resume (stop).
	 * This applies to both suspend to RAM and suspend to disk
	 * (hybernation).
	 */
	bool manage_system_start_stop;

	/*
	 * Let the HLD (sd) manage device runtime suspend (stop) and
	 * resume (start).
	 */
	bool manage_runtime_start_stop;

	/* Let the HLD (sd) manage system power-off (shutdown) */
	bool manage_shutdown;


-- 
Damien Le Moal
Western Digital Research