From: Andrew Morton <akpm@digeo.com>
To: Doug Ledford <dledford@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
linux-scsi@vger.kernel.org
Subject: Re: 2.5.43 IO-APIC bug and spinlock deadlock
Date: Wed, 16 Oct 2002 21:40:24 -0700 [thread overview]
Message-ID: <3DAE3F38.11C9E4F1@digeo.com> (raw)
In-Reply-To: 20021017042851.GQ8159@redhat.com
Doug Ledford wrote:
>
> On Wed, Oct 16, 2002 at 11:33:02PM -0400, Doug Ledford wrote:
> > IO-APIC bug: regular kernel, UP, no IO-APIC or APIC on UP enabled, compile
> > fails (does *everyone* run SMP or at least UP + APIC now?)
>
> OK, this is real.
>
Linus has merged a patch for this. Does it work for you? I don't
think you've sent us any error output.
include/asm-i386/apic.h | 4 ++--
include/asm-i386/smp.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
--- 2.5.43/include/asm-i386/smp.h~mpparse-fix Tue Oct 15 21:26:18 2002
+++ 2.5.43-akpm/include/asm-i386/smp.h Tue Oct 15 21:26:31 2002
@@ -37,6 +37,7 @@
#endif /* CONFIG_CLUSTERED_APIC */
#endif
+#define BAD_APICID 0xFFu
#ifdef CONFIG_SMP
#ifndef __ASSEMBLY__
@@ -65,7 +66,6 @@ extern void zap_low_mappings (void);
* the real APIC ID <-> CPU # mapping.
*/
#define MAX_APICID 256
-#define BAD_APICID 0xFFu
extern volatile int cpu_to_physical_apicid[NR_CPUS];
extern volatile int physical_apicid_to_cpu[MAX_APICID];
extern volatile int cpu_to_logical_apicid[NR_CPUS];
--- 2.5.43/include/asm-i386/apic.h~mpparse-fix Tue Oct 15 21:34:03 2002
+++ 2.5.43-akpm/include/asm-i386/apic.h Tue Oct 15 21:34:05 2002
@@ -7,8 +7,6 @@
#include <asm/apicdef.h>
#include <asm/system.h>
-#ifdef CONFIG_X86_LOCAL_APIC
-
#define APIC_DEBUG 0
#if APIC_DEBUG
@@ -17,6 +15,8 @@
#define Dprintk(x...)
#endif
+#ifdef CONFIG_X86_LOCAL_APIC
+
/*
* Basic functions accessing APICs.
*/
.
next prev parent reply other threads:[~2002-10-17 4:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-17 3:33 2.5.43 IO-APIC bug and spinlock deadlock Doug Ledford
2002-10-17 4:28 ` Doug Ledford
2002-10-17 4:40 ` Andrew Morton [this message]
2002-10-17 5:13 ` Doug Ledford
2002-10-17 8:29 ` Mikael Pettersson
2002-10-17 4:49 ` Zwane Mwaikambo
2002-10-18 19:39 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DAE3F38.11C9E4F1@digeo.com \
--to=akpm@digeo.com \
--cc=dledford@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox