From: Oliver Neukum <oneukum@suse.com>
To: Alan Stern <stern@rowland.harvard.edu>, Keith Busch <kbusch@kernel.org>
Cc: Harald Dunkel <harald.dunkel@aixigo.com>,
Jens Axboe <axboe@kernel.dk>,
Bart Van Assche <bvanassche@acm.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-block@vger.kernel.org, linux-usb@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: RIP on discard, JMicron USB adaptor
Date: Wed, 28 Feb 2024 17:11:16 +0100 [thread overview]
Message-ID: <4111f9ba-e1dc-4158-af6f-c048bcf8ccd2@suse.com> (raw)
In-Reply-To: <76fcb1b1-cdf2-45d0-aeab-c712ee517b34@rowland.harvard.edu>
On 28.02.24 17:01, Alan Stern wrote:
>> In the code comments above the WARN, this condition indicates "the
>> discard granularity isn't set by buggy device driver". The block layer
>> needs this set if your driver also sets the max_discard_sectors limit.
>
> The usb-storage and uas drivers do not set any of these; however, the
> SCSI sd driver does. Maybe that's where the problem lies. Adding more
> CC's.
Hi,
that seems to be conditional on READ_CAPACITY_16 being used.
From the cropped dmesg we cannot tell. We need more.
Regards
Oliver
next prev parent reply other threads:[~2024-02-28 16:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <70bc51d7-c8a2-4b06-ab7a-e321d20db49a@aixigo.com>
[not found] ` <62296d89-f7e6-4f54-add8-35b531dc657c@rowland.harvard.edu>
[not found] ` <Zd9Xbz3L6JEvBHHT@kbusch-mbp>
2024-02-28 16:01 ` RIP on discard, JMicron USB adaptor Alan Stern
2024-02-28 16:11 ` Oliver Neukum [this message]
2024-02-28 21:28 ` Harald Dunkel
2024-02-29 7:31 ` Harald Dunkel
2024-02-29 8:21 ` Harald Dunkel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4111f9ba-e1dc-4158-af6f-c048bcf8ccd2@suse.com \
--to=oneukum@suse.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=harald.dunkel@aixigo.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox