* [PATCH] scsi: ufs: ufs-mediatek: delete some dead code
@ 2023-05-03 10:40 Dan Carpenter
2023-05-03 11:42 ` AngeloGioacchino Del Regno
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Dan Carpenter @ 2023-05-03 10:40 UTC (permalink / raw)
To: Stanley Chu
Cc: James E.J. Bottomley, Martin K. Petersen, Matthias Brugger,
AngeloGioacchino Del Regno, Andy Teng, linux-scsi, linux-mediatek,
linux-arm-kernel, kernel-janitors
There is already a test for "if (val == state)" earlier so it's not
possible here. Delete the dead code.
Fixes: 9006e3986f66 ("scsi: ufs-mediatek: Do not gate clocks if auto-hibern8 is not entered yet")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/ufs/host/ufs-mediatek.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c
index 73e217260390..a054810e321d 100644
--- a/drivers/ufs/host/ufs-mediatek.c
+++ b/drivers/ufs/host/ufs-mediatek.c
@@ -410,9 +410,6 @@ static int ufs_mtk_wait_link_state(struct ufs_hba *hba, u32 state,
usleep_range(100, 200);
} while (ktime_before(time_checked, timeout));
- if (val == state)
- return 0;
-
return -ETIMEDOUT;
}
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: ufs: ufs-mediatek: delete some dead code
2023-05-03 10:40 [PATCH] scsi: ufs: ufs-mediatek: delete some dead code Dan Carpenter
@ 2023-05-03 11:42 ` AngeloGioacchino Del Regno
2023-05-03 14:47 ` Stanley Chu
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-05-03 11:42 UTC (permalink / raw)
To: Dan Carpenter, Stanley Chu
Cc: James E.J. Bottomley, Martin K. Petersen, Matthias Brugger,
Andy Teng, linux-scsi, linux-mediatek, linux-arm-kernel,
kernel-janitors
Il 03/05/23 12:40, Dan Carpenter ha scritto:
> There is already a test for "if (val == state)" earlier so it's not
> possible here. Delete the dead code.
>
> Fixes: 9006e3986f66 ("scsi: ufs-mediatek: Do not gate clocks if auto-hibern8 is not entered yet")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: ufs: ufs-mediatek: delete some dead code
2023-05-03 10:40 [PATCH] scsi: ufs: ufs-mediatek: delete some dead code Dan Carpenter
2023-05-03 11:42 ` AngeloGioacchino Del Regno
@ 2023-05-03 14:47 ` Stanley Chu
2023-05-06 22:46 ` Martin K. Petersen
2023-05-17 2:12 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Stanley Chu @ 2023-05-03 14:47 UTC (permalink / raw)
To: Dan Carpenter
Cc: Stanley Chu, James E.J. Bottomley, Martin K. Petersen,
Matthias Brugger, AngeloGioacchino Del Regno, Andy Teng,
linux-scsi, linux-mediatek, linux-arm-kernel, kernel-janitors
Dan Carpenter <dan.carpenter@linaro.org> 於 2023年5月3日 週三 下午6:41寫道：
>
> There is already a test for "if (val == state)" earlier so it's not
> possible here. Delete the dead code.
>
> Fixes: 9006e3986f66 ("scsi: ufs-mediatek: Do not gate clocks if auto-hibern8 is not entered yet")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: ufs: ufs-mediatek: delete some dead code
2023-05-03 10:40 [PATCH] scsi: ufs: ufs-mediatek: delete some dead code Dan Carpenter
2023-05-03 11:42 ` AngeloGioacchino Del Regno
2023-05-03 14:47 ` Stanley Chu
@ 2023-05-06 22:46 ` Martin K. Petersen
2023-05-17 2:12 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2023-05-06 22:46 UTC (permalink / raw)
To: Dan Carpenter
Cc: Stanley Chu, James E.J. Bottomley, Martin K. Petersen,
Matthias Brugger, AngeloGioacchino Del Regno, Andy Teng,
linux-scsi, linux-mediatek, linux-arm-kernel, kernel-janitors
Dan,
> There is already a test for "if (val == state)" earlier so it's not
> possible here. Delete the dead code.
Applied to 6.5/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: ufs: ufs-mediatek: delete some dead code
2023-05-03 10:40 [PATCH] scsi: ufs: ufs-mediatek: delete some dead code Dan Carpenter
` (2 preceding siblings ...)
2023-05-06 22:46 ` Martin K. Petersen
@ 2023-05-17 2:12 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2023-05-17 2:12 UTC (permalink / raw)
To: Stanley Chu, Dan Carpenter
Cc: Martin K . Petersen, James E.J. Bottomley, Matthias Brugger,
AngeloGioacchino Del Regno, Andy Teng, linux-scsi, linux-mediatek,
linux-arm-kernel, kernel-janitors
On Wed, 03 May 2023 13:40:59 +0300, Dan Carpenter wrote:
> There is already a test for "if (val == state)" earlier so it's not
> possible here. Delete the dead code.
>
>
Applied to 6.5/scsi-queue, thanks!
[1/1] scsi: ufs: ufs-mediatek: delete some dead code
https://git.kernel.org/mkp/scsi/c/19c9322e36a0
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-17 2:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-03 10:40 [PATCH] scsi: ufs: ufs-mediatek: delete some dead code Dan Carpenter
2023-05-03 11:42 ` AngeloGioacchino Del Regno
2023-05-03 14:47 ` Stanley Chu
2023-05-06 22:46 ` Martin K. Petersen
2023-05-17 2:12 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox