From: John Garry <john.garry@huawei.com>
To: Jason Yan <yanaijie@huawei.com>, <martin.petersen@oracle.com>,
<jejb@linux.ibm.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<hare@suse.com>, <hch@lst.de>, <bvanassche@acm.org>,
<jinpu.wang@cloud.ionos.com>
Subject: Re: [PATCH v2 5/8] scsi: libsas: introduce sas address comparation helpers
Date: Mon, 26 Sep 2022 12:44:41 +0100 [thread overview]
Message-ID: <41f4fee1-d05c-94cf-480e-4e9f6cf873bb@huawei.com> (raw)
In-Reply-To: <20220924073455.2186805-6-yanaijie@huawei.com>
On 24/09/2022 08:34, Jason Yan wrote:
> +static inline bool sas_phy_match_dev_addr(struct domain_device *dev,
> + struct ex_phy *phy)
> +{
> + return SAS_ADDR(dev->sas_addr) == SAS_ADDR(phy->attached_sas_addr);
> +}
> +
> +static inline bool sas_phy_match_port_addr(struct asd_sas_port *port,
> + struct ex_phy *phy)
> +{
> + return SAS_ADDR(port->sas_addr) == SAS_ADDR(phy->attached_sas_addr);
> +}
> +
> +static inline bool sas_phy_addr_same(struct ex_phy *p1, struct ex_phy *p2)
nit: please use "match" or "same" consistently in the naming. My
preference was for "match" to be used.
Thanks,
John
> +{
> + return SAS_ADDR(p1->attached_sas_addr) == SAS_ADDR(p2->attached_sas_addr);
> +}
> +
next prev parent reply other threads:[~2022-09-26 14:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-24 7:34 [PATCH v2 0/8] scsi: libsas: sas address comparation refactor Jason Yan
2022-09-24 7:34 ` [PATCH v2 1/8] scsi: libsas: introduce sas_find_attached_phy() helper Jason Yan
2022-09-24 7:34 ` [PATCH v2 2/8] scsi: pm8001: use sas_find_attached_phy() instead of open coded Jason Yan
2022-09-24 7:34 ` [PATCH v2 3/8] scsi: mvsas: " Jason Yan
2022-09-24 7:34 ` [PATCH v2 4/8] scsi: hisi_sas: use sas_find_attathed_phy() " Jason Yan
2022-09-24 7:34 ` [PATCH v2 5/8] scsi: libsas: introduce sas address comparation helpers Jason Yan
2022-09-26 11:44 ` John Garry [this message]
2022-09-26 12:16 ` Jason Yan
2022-09-24 7:34 ` [PATCH v2 6/8] scsi: libsas: use sas_phy_match_dev_addr() instead of open coded Jason Yan
2022-09-26 11:43 ` John Garry
2022-09-26 12:18 ` Jason Yan
2022-09-24 7:34 ` [PATCH v2 7/8] scsi: libsas: use sas_phy_addr_same() " Jason Yan
2022-09-24 7:34 ` [PATCH v2 8/8] scsi: libsas: use sas_phy_match_port_addr() " Jason Yan
2022-09-26 6:09 ` [PATCH v2 0/8] scsi: libsas: sas address comparation refactor Jinpu Wang
2022-09-26 6:37 ` Jason Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41f4fee1-d05c-94cf-480e-4e9f6cf873bb@huawei.com \
--to=john.garry@huawei.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox