public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Douglas Gilbert <dougg@torque.net>
To: "Kristian Høgsberg" <krh@bitplanet.net>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
	linux1394-devel@lists.sourceforge.net,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH] ieee1394: sbp2: remove bogus "emulated" host flag
Date: Mon, 15 Jan 2007 15:40:02 -0500	[thread overview]
Message-ID: <45ABE6A2.10509@torque.net> (raw)
In-Reply-To: <59ad55d30701151141n72e3e99ey509d859c272b8bda@mail.gmail.com>

Kristian Høgsberg wrote:
> On 1/14/07, Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
>> There is no emulation going on here.
> ...
> 
>> -       .emulated                = 1,
> 
> Not sure what this flag does, but I copied it over to fw-sbp2.c.  If
> it's bogus, I guess we should drop it from fw-sbp2.c too.

Kristian,
The 'emulated' flag dates from the original ide-scsi
driver (lk 2.0 series or earlier) when some app wanted
to know if there was a "real" SCSI cd drive attached
or a fudged one (i.e. ATAPI) via the ide-scsi bridging
driver. So it is unclear to me why the sbp driver
(and USB mass storage) sets emulated.

Hopefully if any app cares these days there are much
better ways to find out what the transport is. Also
now we have the transport the LLD can see
and the transport the device (i.e. logical unit) can
see; and they aren't necessarily the same. In the
case of a CD/DVD drive there is the GET CONFIGURATION
command for finding out what the lu can see:
$ sg_get_config /dev/hdc
  HL-DT-ST  RW/DVD GCC-4242N  0201
  Peripheral device type: cd/dvd
No current profile
Features:
  Profile list feature
    version=0, persist=1, current=1 [0x0]
    available profiles [more recent typically higher in list]:
      profile: DVD-ROM , currentP=0
      profile: CD-ROM , currentP=0
      profile: CD-R , currentP=0
      profile: CD-RW , currentP=0
  Core feature
    version=0, persist=1, current=1 [0x1]
      Physical interface standard: ATAPI
......

So IMO 'emulated' is best retired.

Doug Gilbert

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2007-01-15 20:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-14 18:40 [PATCH] ieee1394: sbp2: remove bogus "emulated" host flag Stefan Richter
2007-01-15 19:41 ` Kristian Høgsberg
2007-01-15 20:40   ` Douglas Gilbert [this message]
2007-01-15 21:11     ` Kristian Høgsberg
2007-01-15 20:49   ` Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45ABE6A2.10509@torque.net \
    --to=dougg@torque.net \
    --cc=krh@bitplanet.net \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox